Improve performance: Don't request current context when creating a measurement#4253
Improve performance: Don't request current context when creating a measurement#4253fcollonval wants to merge 1 commit intoopen-telemetry:mainfrom
Conversation
|
@emdneto here is my attempt to restore code performance to its level prior to the introduction of the exemplar in #4094 As the project has been released with the new API for measurement, aka it has a Do you think it would be better to drop the Would it make sense to add benchmark with exemplar deactivated? If so what is the best way of doing so?
|
|
This PR has been automatically marked as stale because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 days of this comment. |
|
This PR has been closed due to inactivity. Please reopen if you would like to continue working on it. |
Description
Fixes #4243
Make
Measurement.contextoptional and stop requesting the current context when creating a measurementType of change
Improve code performance following degradation with #4094
How Has This Been Tested?
I run locally the benchmarks to check the improvement.
I also tried the metrics benchmark with exemplar deactivate (aka setting exemplar filter to always off); it also show slight performance boost
Does This PR Require a Contrib Repo Change?
Checklist: