Fix AttributeError when invalid type passed to attributes on Python 3.9#5018
Closed
pkb94 wants to merge 2 commits intoopen-telemetry:mainfrom
Closed
Fix AttributeError when invalid type passed to attributes on Python 3.9#5018pkb94 wants to merge 2 commits intoopen-telemetry:mainfrom
pkb94 wants to merge 2 commits intoopen-telemetry:mainfrom
Conversation
On Python 3.9, typing generics like Mapping and Sequence lack __name__, causing AttributeError instead of TypeError when an invalid type is passed to _clean_extended_attribute_value. Use getattr with fallback to _name to safely handle these types. Fixes open-telemetry#4821 Signed-off-by: Pooja Kittanakere Balaji <pk73@njit.edu>
Signed-off-by: Pooja Kittanakere Balaji <pk73@njit.edu>
|
Contributor
|
Closing as duplicate of #4876 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Python 3.9, typing generics like Mapping and Sequence lack name, causing AttributeError instead of TypeError when an invalid type is passed to _clean_extended_attribute_value. Use getattr with fallback to _name to safely handle these types.
Fixes #4821
Description
Fixes #4821
Bug Fix
Please delete options that are not relevant.
How Has This Been Tested?
Added test
test_invalid_type_raises_type_error_not_attribute_errorinopentelemetry-api/tests/attributes/test_attributes.py.The test passes an object whose
__str__raises an exception to_clean_extended_attribute_valueand asserts that aTypeErroris raised(not
AttributeError) with the expected message content.Run with:
python3 -m tox -e py39-test-opentelemetry-api -- opentelemetry-api/tests/attributes/test_attributes.py
Does This PR Require a Contrib Repo Change?
Checklist: