Fixed debug field usage in zipkin exporter#549
Merged
c24t merged 1 commit intoopen-telemetry:masterfrom Apr 4, 2020
Merged
Conversation
Zipkin spec expects the debug field to be a boolean, not an integer. OpenTelemetry collector rejects spans exported by the Python Zipkin exporter with the following error message: ``` Traces cannot be uploaded; status code: 400, message json: cannot unmarshal number into Go struct field .debug of type bool ``` Zipkin data model confirm that the field should be a boolean here: https://zipkin.io/zipkin-api/
mauriciovasquezbernal
approved these changes
Apr 3, 2020
Member
mauriciovasquezbernal
left a comment
mauriciovasquezbernal
left a comment
There was a problem hiding this comment.
Thanks for the fix. LGTM!
Contributor
|
sampled != debug though https://github.com/openzipkin/b3-propagation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zipkin spec expects the debug field to be a boolean, not an integer. OpenTelemetry collector rejects spans exported by the Python Zipkin exporter with the following error message:
Zipkin data model confirms that the field should be a boolean here: https://zipkin.io/zipkin-api/