Fix span.status

[gky360]

Fixes the error caused by span.status in use_span.

As status is not included in opentelemetry.trace.Span, span.status in use_span may cause an error.
For example, when use_span is called with DefaultSpan, it causes the error below.

'DefaultSpan' object has no attribute 'status'

[gky360]

I signed it

[mauriciovasquezbernal]

Hi @gky360, welcome!

Your solution looks good by I think we could do it slightly different, what do you think about adding isinstance(span, Span) to the condition below?

opentelemetry-python/opentelemetry-sdk/src/opentelemetry/sdk/trace/__init__.py

Lines 607 to 610 in c8b336d

	if (
	span.status is None
	and span._set_status_on_exception # pylint:disable=protected-access # noqa
	):

It would also be nice to include a test to avoid this error happening again, I think you can do something like:

# define what MyCustomException is
default_span = trace_api.DefaultSpan() # probably context is needed
with self.assertRaises(MyCustomException):
  with tracer.use_span(default_span):
    raise MyCustomException

The goal is to be sure that the raised exception passes without being modified (not new exceptions are raised).
You can get more inspiration here

opentelemetry-python/opentelemetry-sdk/tests/trace/test_trace.py

Line 713 in c8b336d

def test_error_status(self):

.

[mauriciovasquezbernal]

LGTM, thanks!

[gky360]

Thank you for the review!

[codeboten]

Nice, thanks for the contribution and for adding the test!