Add instructions to proto package README#905
Merged
lzchen merged 6 commits intoopen-telemetry:masterfrom Jul 16, 2020
Merged
Conversation
aabmass
commented
Jul 13, 2020
aabmass
force-pushed
the
proto-readme-894
branch
from
e70c294 to
ddba3dc
Compare
codeboten
approved these changes
Jul 14, 2020
Contributor
codeboten
left a comment
codeboten
left a comment
There was a problem hiding this comment.
Thanks for adding this documentation, it will come in handy next time we need to generate new protos!
ocelotl
approved these changes
Jul 14, 2020
lzchen
approved these changes
Jul 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #894. Added instructions to run
./scripts/proto_codegen.shto regenerate code.@ocelotl also mentioned the virtualenv check was confusing, so I removed it. Instead, the script just creates its own temporary virtualenv on each run to get a repeatable build.