Change default Sampler to ParentOrElse(AlwaysOn)#960
Merged
lzchen merged 4 commits intoopen-telemetry:masterfrom Aug 4, 2020
Merged
Change default Sampler to ParentOrElse(AlwaysOn)#960lzchen merged 4 commits intoopen-telemetry:masterfrom
lzchen merged 4 commits intoopen-telemetry:masterfrom
Conversation
ocelotl
approved these changes
Jul 30, 2020
codeboten
approved these changes
Jul 31, 2020
Contributor
codeboten
left a comment
codeboten
left a comment
There was a problem hiding this comment.
This looks good, @MitchellDumovic if you could resolve the conflict.
MitchellDumovic
force-pushed
the
mitchell/change-default-sampler
branch
from
e7c2042 to
c5e6368
Compare
srikanthccv
pushed a commit
to srikanthccv/opentelemetry-python
that referenced
this pull request
Nov 1, 2020
url.URL from the standard library should be used instead of the global URL which comes from the dom lib. Signed-off-by: Naseem <naseem@transit.app>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See open-telemetry/opentelemetry-specification#750 and associated issue open-telemetry/opentelemetry-specification#728
Type of change
Checklist: