test: continue switch to rspec-mocks

[thompson-tomo]

This continues the work in #2011

For Reviewers

Minitests stub method used a block to maintain the scope of the invocation. Switching to rspec mocks resulted in the block being removed and the white space changing in many places in the code so I recommend that you review this using "Hide the white space changes": https://github.com/open-telemetry/opentelemetry-ruby-contrib/pull/2059/changes?w=1

[arielvalentin]

Thanks for doing this.

Something I'm trying to understand is if @open-telemetry/ruby-contrib-mainters are in agreement that we converge on using rspec mocks, or if we should exclusively use minitest

[thompson-tomo]

No worries, I was just looking to unblock the renovate pr for minitest by replicating your previous work. 😉 hence the other pr #2061.

[robbkidd]

While we figure out minitest vs rspec, I found one thing that needs looking into.

[robbkidd]

This test [for instrumentation-rake] fails on my machine. Not sure why it didn't fail in CI.

Er, I know why now. instrumentation-rake isn't named in the CI test matrix. 😬

Git spelunking turns up that the rake instrumentation was added around the same time as the old single CI definition was split into different workflows. I'm pretty sure we missed adding rake to the test matrix. 😅

We should update ci-instrumentation-full (rake needs no services):

• insert "instrumentation/rake/**" between rack and rails in the path_filters
• insert "rake" between rack and rails in the gem matrix

@thompson-tomo, would you be up for including that CI update in this PR? 🥺

[thompson-tomo]

@robbkidd thanks for looking into that, i have made the above changes in #2099 to avoid it being held up in rspec-mocks vs minitest discussion.

The change requested was done.