feat: draft - PG semantic convention stability migration#2076
feat: draft - PG semantic convention stability migration#2076hannahramadan wants to merge 5 commits intoopen-telemetry:mainfrom
Conversation
| # By default, this instrumentation obfuscates/sanitizes the executed SQL as the `db.statement` | ||
| # semantic attribute. Optionally, you may disable the inclusion of this attribute entirely by | ||
| # setting this option to :omit or disable sanitization of the attribute by setting it to :include | ||
| db_statement: :include, |
There was a problem hiding this comment.
I know that it is out of scope of this PR, but would you be willing to also document the obfuscation_limit: 2000 parameter in this file, please?
The description would be something like:
When enabled by
db_statement, this instrumentation will not obfuscate SQL queries longer than 2000 characters. The default limit can be overridden by setting theobfuscation_limitto another integer value.
There was a problem hiding this comment.
The config was released in v0.25.0 (on 2023-05-25), but never documented it seems.
There was a problem hiding this comment.
It's going to be a while before this is ready for review and merged.
@toncid would you be amenable to submitting a PR that documents the option?
There was a problem hiding this comment.
Sure, no problem. Thanks for the quick answer.
This PR is intended to assist in the transition from the old to new database semantic conventions. Per the database semantic convention stability migration spec, users should be able to set the environment variable
OTEL_SEMCONV_STABILITY_OPT_INto:databaseto emit stable conventions onlydatabase/dupto emit both old and the stable conventionsThe agent is required to maintain this bridge for 6 months and may drop the environment variable in the next major version and emit only the stable database and networking conventions.
This approach was approved for HTTP migration in #1547
Changes:
Removed:
Added: