Add CONTRIBUTING guide#104
Merged
fbogsany merged 1 commit intoopen-telemetry:masterfrom Sep 24, 2019
mutations:add-contributing
Merged
Add CONTRIBUTING guide#104fbogsany merged 1 commit intoopen-telemetry:masterfrom mutations:add-contributing
fbogsany merged 1 commit intoopen-telemetry:masterfrom
mutations:add-contributing
Conversation
Adds initial contributing guide.
fbogsany
approved these changes
Sep 24, 2019
Contributor
fbogsany
left a comment
There was a problem hiding this comment.
Thanks @elskwid! I like this as is. I also like the "things we could add", but I'd be happy to merge this as is and open issues to add those things. I've been thinking recently about the first one, since we have some distinct Ruby-isms in our codebase that differ significantly from other implementations.
Member
Author
|
@fbogsany Thanks for the review! I'm perfectly happy with a merge now. I can create issues for the "things we could add" and we can set aside time later on. |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Adds initial contributing guide.
Details
Adds a starting point for our contributing guide focused on the basic process of:
Things we could add
There might be some other things we could add in here like: