Declare freeze of Trace API Specification 1.0 by tigrannajaryan · Pull Request #1121 · open-telemetry/opentelemetry-specification

tigrannajaryan · 2020-10-20T20:35:54Z

We want to freeze Trace API specification 1.0 so that we no longer accept substantial changes (unless a fundamental problem is found in the spec).

Contributes to #1120

specification/document-status.md

Oberon00 · 2020-10-23T07:52:11Z

Please make sure to keep this in ready-for-review state a long enough time and not merge it straight out of draft state.

github-actions · 2020-10-31T03:16:19Z

This PR was marked stale due to lack of activity. It will be closed in 7 days.

tigrannajaryan · 2020-11-03T16:52:43Z

This is ready for review, but don't merge.

specification/document-status.md

Oberon00

The set of documents frozen does not include resources and common. I think at least common/ needs to be frozen before trace. resources/ also needs to be frozen before tracing goes GA.
EDIT: Semantic conventions are also not included which seems fine. Although maybe exception semantic conventions should be frozen, since we have record_exception referencing it from the trace API spec.

specification/trace/sdk_exporters/zipkin.md

bogdandrutu

Overall LGTM, but need to make sure we close all PRs before merging this.

tigrannajaryan · 2020-11-09T17:35:03Z

Discussed in the Maintainers meeting. For now this PR includes only Trace API, but not Trace SDK. We would like to get this merged today or tomorrow. Please review.

andrewhsu

LGTM

Oberon00

I think we need to also freeze the attributes sections of common/common.md: https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/common/common.md#attributes and for that I'd like to see #1203 resolved. EDIT: And #1213.

bogdandrutu

Please also freeze the common as @Oberon00 suggested

tigrannajaryan · 2020-11-12T15:26:49Z

specification/common/common.md is now part of this freeze.

specification/common/common.md

We want to freeze Trace specification 1.0 so that we no longer accept substantial changes (unless a fundamental problem is found in the spec). Resolves open-telemetry#1120

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>

specification/common/common.md

specification/common/attribute-and-label-naming.md

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>

tigrannajaryan · 2020-11-17T19:57:05Z

I think this is good to merge.

carlosalberto · 2020-11-17T21:41:38Z

We got enough approvals and the last two pending issues we had were solved. Merging now!

* Declare freeze of Trace Specification 1.0 We want to freeze Trace specification 1.0 so that we no longer accept substantial changes (unless a fundamental problem is found in the spec). Resolves open-telemetry#1120

Co-authored-by: Liudmila Molkova <limolkova@microsoft.com>

tigrannajaryan requested review from a team October 20, 2020 20:35

github-actions bot assigned bogdandrutu Oct 20, 2020

tigrannajaryan marked this pull request as draft October 20, 2020 20:36

tigrannajaryan commented Oct 20, 2020

View reviewed changes

specification/document-status.md Outdated Show resolved Hide resolved

carlosalberto approved these changes Oct 23, 2020

View reviewed changes

arminru added release:required-for-ga Must be resolved before GA release, or nice to have before GA spec:trace Related to the specification/trace directory labels Oct 23, 2020

github-actions bot added the Stale label Oct 31, 2020

tigrannajaryan force-pushed the feature/tigran/freeze-trace-spec branch from 76def07 to ce81306 Compare November 3, 2020 16:51

tigrannajaryan marked this pull request as ready for review November 3, 2020 16:52

github-actions bot assigned jmacd Nov 3, 2020

tigrannajaryan changed the title ~~Declare freeze of Trace Specification 1.0~~ [REVIEW BUT DON'T MERGE] Declare freeze of Trace Specification 1.0 Nov 3, 2020

arminru approved these changes Nov 3, 2020

View reviewed changes

specification/document-status.md Outdated Show resolved Hide resolved

Oberon00 reviewed Nov 3, 2020

View reviewed changes

specification/trace/sdk_exporters/zipkin.md Outdated Show resolved Hide resolved

github-actions bot removed the Stale label Nov 4, 2020

bogdandrutu approved these changes Nov 4, 2020

View reviewed changes

tigrannajaryan force-pushed the feature/tigran/freeze-trace-spec branch from 0ca12f4 to 3de0b2a Compare November 9, 2020 17:30

tigrannajaryan changed the title ~~[REVIEW BUT DON'T MERGE] Declare freeze of Trace Specification 1.0~~ Declare freeze of Trace Specification 1.0 Nov 9, 2020

tigrannajaryan changed the title ~~Declare freeze of Trace Specification 1.0~~ Declare freeze of Trace API Specification 1.0 Nov 9, 2020

MrAlias approved these changes Nov 9, 2020

View reviewed changes

andrewhsu approved these changes Nov 9, 2020

View reviewed changes

Oberon00 reviewed Nov 9, 2020

View reviewed changes

bogdandrutu approved these changes Nov 10, 2020

View reviewed changes

jmacd approved these changes Nov 10, 2020

View reviewed changes

tigrannajaryan force-pushed the feature/tigran/freeze-trace-spec branch from 201a6a8 to 7dac4a4 Compare November 12, 2020 15:26

Oberon00 added the area:api Cross language API specification issue label Nov 12, 2020

Oberon00 reviewed Nov 12, 2020

View reviewed changes

specification/common/common.md Show resolved Hide resolved

Tigran Najaryan and others added 7 commits November 16, 2020 11:57

Declare freeze of Trace Specification 1.0

0b71f05

We want to freeze Trace specification 1.0 so that we no longer accept substantial changes (unless a fundamental problem is found in the spec). Resolves open-telemetry#1120

Fixes based on PR comments

2700efb

Change "Pre-approved" to "Feature-complete"

de4ed48

Change "Feature-complete" to "Feature-freeze"

f422452

Adjust labels based on discussion in Maintainers meeting

c47f1ad

Update specification/document-status.md

062d0fa

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>

Add common (attributes) to spec freeze

4315893

tigrannajaryan force-pushed the feature/tigran/freeze-trace-spec branch from 7dac4a4 to 4315893 Compare November 16, 2020 16:58

bogdandrutu approved these changes Nov 16, 2020

View reviewed changes

specification/common/common.md Show resolved Hide resolved

Remove metric labes from freeze

b5801b9

arminru approved these changes Nov 17, 2020

View reviewed changes

specification/common/common.md Show resolved Hide resolved

Oberon00 approved these changes Nov 17, 2020

View reviewed changes

specification/common/common.md Show resolved Hide resolved

Oberon00 reviewed Nov 17, 2020

View reviewed changes

specification/common/attribute-and-label-naming.md Show resolved Hide resolved

Update specification/common/common.md

1679495

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>

SergeyKanzhelev approved these changes Nov 17, 2020

View reviewed changes

carlosalberto approved these changes Nov 17, 2020

View reviewed changes

carlosalberto merged commit 82865fa into open-telemetry:master Nov 17, 2020

tigrannajaryan deleted the feature/tigran/freeze-trace-spec branch March 19, 2021 14:18

Oberon00 mentioned this pull request Oct 19, 2022

Propose Context-scoped attributes. open-telemetry/oteps#207

Closed

schmikei pushed a commit to schmikei/opentelemetry-specification that referenced this pull request Apr 17, 2025

added note about abbreviations (open-telemetry#1121)

3b7dd89

Co-authored-by: Liudmila Molkova <limolkova@microsoft.com>

Conversation

tigrannajaryan commented Oct 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Oberon00 commented Oct 23, 2020

Uh oh!

github-actions bot commented Oct 31, 2020

Uh oh!

tigrannajaryan commented Nov 3, 2020

Uh oh!

Uh oh!

Oberon00 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bogdandrutu left a comment

Choose a reason for hiding this comment

Uh oh!

tigrannajaryan commented Nov 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

andrewhsu left a comment

Choose a reason for hiding this comment

Uh oh!

Oberon00 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bogdandrutu left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tigrannajaryan commented Nov 12, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tigrannajaryan commented Nov 17, 2020

Uh oh!

carlosalberto commented Nov 17, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

tigrannajaryan commented Oct 20, 2020 •

edited

Loading

Oberon00 left a comment •

edited

Loading

tigrannajaryan commented Nov 9, 2020 •

edited

Loading

Oberon00 left a comment •

edited

Loading

bogdandrutu left a comment •

edited

Loading