Skip to content

Change Option<bool> storage to Option<()>.#215

Merged
shaunxw merged 1 commit intomasterfrom
sw/empty-storage-value
Jun 28, 2020
Merged

Change Option<bool> storage to Option<()>.#215
shaunxw merged 1 commit intomasterfrom
sw/empty-storage-value

Conversation

@shaunxw
Copy link
Member

@shaunxw shaunxw commented Jun 26, 2020

Close #210

@shaunxw shaunxw requested a review from xlc June 26, 2020 04:38
@JoshOrndorff
Copy link
Contributor

Have you tried reading state from offchain with the () storage value? Like from polkadot-js API for example? I have not yet.

@xlc
Copy link
Member

xlc commented Jun 27, 2020

polkadot.js should support it, otherwise I don't see any major blockers for us to fix it.

@shaunxw shaunxw merged commit 7c96caf into master Jun 28, 2020
@shaunxw shaunxw deleted the sw/empty-storage-value branch June 28, 2020 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace Option<bool> storage to Option<()>

3 participants