Implement fungible and fungibles for tokens#517
Merged
Conversation
xlc
reviewed
Jun 10, 2021
| source: &T::AccountId, | ||
| dest: &T::AccountId, | ||
| amount: T::Balance, | ||
| _keep_alive: bool, |
Member
Author
There was a problem hiding this comment.
open-runtime-module-library/tokens/src/lib.rs
Lines 519 to 538 in 7cd2c10
Tokens
transfer not handle the ExistenceRequirement
Member
There was a problem hiding this comment.
we need a version that handles it, and transfer can call it with keep_alive: false
shaunxw
reviewed
Jun 10, 2021
xlc
reviewed
Jun 12, 2021
| from: &AccountId, | ||
| to: &AccountId, | ||
| amount: Self::Balance, | ||
| existence_requirement: ExistenceRequirement, |
Member
There was a problem hiding this comment.
this will break too many existing code.
I was thinking only update the transfer implementation of orml-tokens. Add a new helper method to take existence_requirement.
xlc
reviewed
Jun 14, 2021
| from: &AccountId, | ||
| to: &AccountId, | ||
| amount: Self::Balance, | ||
| existence_requirement: ExistenceRequirement, |
xlc
approved these changes
Jun 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#417
currencies module is updating.