[XNFT PoC] xtokens non-fungible multiassets support#966
Merged
xlc merged 3 commits intoopen-web3-stack:masterfrom Nov 21, 2023
Merged
[XNFT PoC] xtokens non-fungible multiassets support#966xlc merged 3 commits intoopen-web3-stack:masterfrom
xlc merged 3 commits intoopen-web3-stack:masterfrom
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #966 +/- ##
==========================================
+ Coverage 85.32% 85.50% +0.17%
==========================================
Files 88 88
Lines 10476 10533 +57
==========================================
+ Hits 8939 9006 +67
+ Misses 1537 1527 -10 ☔ View full report in Codecov by Sentry. |
xlc
reviewed
Nov 20, 2023
Member
xlc
left a comment
There was a problem hiding this comment.
some tests to ensure sending nft are actually working?
xlc
approved these changes
Nov 21, 2023
simonsso
pushed a commit
to NodleCode/open-runtime-module-library
that referenced
this pull request
Jan 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A change to the
do_transfer_multiassets: support of theNonFungiblefungibility for non-fee assets.This PR doesn't change the API of extrinsics that use the configurable
CurrencyIdsince it is a PoC. In the future, we could alter theamountargument to take the fungibility into account.So only the following extrinsics can be used to transfer an NFT asset:
transferMultiassettransferMultiassetWithFeetransferMultiassets