Bump the all-dependencies group with 14 updates - #281
Conversation
✅ Deploy Preview for openworkflow-editor ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
Updates the dependency set (notably @openworkflowspec/sdk) and aligns test expectations with updated workflow graph/node identity behavior by refreshing snapshots and Playwright E2E selectors.
Changes:
- Updated
buildFlatGraphintegration snapshot to reflect new node IDs and addedtaskReferencefields. - Updated Playwright E2E tests to use the new node/test-id formats (removing numeric index segments like
/do/0/...). - Reduced assertions in one E2E test that previously verified node-level validation error UI.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/open-workflow-diagram-editor/tests/core/snapshots/workflowSdk.integration.test.ts.snap | Snapshot updated for new graph node IDs and taskReference fields. |
| packages/open-workflow-diagram-editor/tests-e2e/forever-foreach.spec.ts | E2E selector updated; error-related assertions removed. |
| packages/open-workflow-diagram-editor/tests-e2e/for-loop.spec.ts | E2E selectors updated for new node/test-id formats. |
| packages/open-workflow-diagram-editor/tests-e2e/diagram-editor.spec.ts | Updated React Flow node test-id to match new node IDs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 6 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
packages/open-workflow-diagram-editor/tests-e2e/forever-foreach.spec.ts:28
- This test is named as validating an error state, but it no longer asserts that the node actually renders a validation error indicator (error badge /
has-errorclass). Given the SDK change that decouples node IDs from document paths, this risks masking a regression where validation errors no longer attach to nodes.
await expect(page.getByTestId("listen-node-/do/listenToGossips-badge")).toHaveText("any");
});
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 6 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
packages/open-workflow-diagram-editor/tests-e2e/forever-foreach.spec.ts:27
- This change removes the only end-to-end assertions that validation errors are rendered on nodes (error badge visibility and
has-errorclass). After this PR,tests-e2eno longer appears to cover node-level error highlighting, which makes it easier for SDK-breaking changes to regress UI error feedback without detection.
Consider adding/keeping an E2E scenario that intentionally triggers a node-owned validation error and asserts the node shows the error badge and has-error class (updating testIds to the new node identity scheme).
test("renders listen node with any badge", async ({ page }) => {
await page.goto("/iframe.html?id=examples-workflows--listen-to-any-forever-foreach");
const node = page.getByTestId("listen-node-/do/listenToGossips");
await expect(node).toContainText("listenToGossips");
await expect(node).toContainText("LISTEN");
await expect(page.getByTestId("listen-node-/do/listenToGossips-badge")).toHaveText("any");
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
packages/open-workflow-diagram-editor/tests-e2e/forever-foreach.spec.ts:23
- This test used to assert node-level validation UI (error badge +
has-errorclass) but now only checks the badge text. Given the@openworkflowspec/sdkupdate decouples node IDs from document paths (graph snapshot IDs like "/do/step1" vs validation error paths like "/do/0/checkup" in workflowSdk.integration snapshots), removing these assertions may hide a regression where node errors no longer attach to the correct node. Please add/restore an end-to-end check for node-level errors (e.g. Storybookfeatures-validation-errors--node-error) and ensure error-to-node mapping uses the graph node’staskReference(document path) rather thanid.
test("renders listen node with any badge", async ({ page }) => {
await page.goto("/iframe.html?id=examples-workflows--listen-to-any-forever-foreach");
const node = page.getByTestId("listen-node-/do/listenToGossips");
lornakelly
left a comment
There was a problem hiding this comment.
LGTM @kumaradityaraj but please look at the DCO check
|
@kumaradityaraj Please also close the original dependabot PR with comment that you are closing in favour of this PR |
Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>
Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>
Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>
8f3f5cb to
052badb
Compare
Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 6 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (3)
packages/open-workflow-diagram-editor/tests-e2e/forever-foreach.spec.ts:28
- The test previously asserted validation-error UI (error element visibility and
has-errorclass) but those assertions were removed. If the validation error behavior is still expected/important, add a dedicated E2E case (or a separate story) that deterministically triggers the error state and asserts the error UI, so regressions don’t slip through.
test("renders listen node with any badge", async ({ page }) => {
await page.goto("/iframe.html?id=examples-workflows--listen-to-any-forever-foreach");
const node = page.getByTestId("listen-node-/do/listenToGossips");
await expect(node).toContainText("listenToGossips");
await expect(node).toContainText("LISTEN");
await expect(page.getByTestId("listen-node-/do/listenToGossips-badge")).toHaveText("any");
});
packages/open-workflow-diagram-editor/tests/core/snapshots/workflowSdk.integration.test.ts.snap:109
- The new output shape has
idandtaskReferencediverging (/do/step1vs/do/0/step1). IftaskReferenceis intended to be the original SDK task path, consider documenting that contract (or renaming the field to be explicit) and ensuring downstream code never assumestaskReference === id. Otherwise, align the values to avoid ambiguous identifiers.
"id": "/do/step1",
"label": "step1",
"parent": [Circular],
"task": {
"set": {
"variable": "first task",
},
},
"taskReference": "/do/0/step1",
"type": "set",
packages/open-workflow-diagram-editor/tests/core/snapshots/workflowSdk.integration.test.ts.snap:163
taskReference: undefinedis now emitted on nodes where it’s not applicable (e.g., root). If this reflects the actual runtime object shape, consider omitting the property entirely when it’s undefined to keep the graph structure cleaner and more JSON-friendly, and to reduce snapshot churn when adding optional fields.
],
"parent": undefined,
"task": undefined,
"taskReference": undefined,
"type": "root",
fantonangeli
left a comment
There was a problem hiding this comment.
@kumaradityaraj Thanks you.
This PR aligns DE with open-workflow-specification/sdk-typescript#289
ae594ed
into
open-workflow-specification:main
Closes #277
Bumps the all-dependencies group with 14 updates:
1.0.3-alpha41.0.3-alpha510.5.210.5.310.5.210.5.310.5.210.5.310.5.210.5.36.9.17.0.017.0.817.1.11.25.01.26.00.59.00.60.01.74.01.75.01.6.21.6.519.2.719.2.819.2.719.2.810.5.210.5.3Invalid tests have been removed and some tests have been mofidied