Handled ALT's register-yourself forwarding PromptForEmbeddingInitiatesEmbeddingProcess.RequestForBequeathingData via pass by value#1016
Merged
Conversation
sunil-kumar-meena
requested review from
DanaSunal,
IswaryaaS,
MartinSunal,
PrathibaJee and
vanithavalluripalli9
as code owners
PrathibaJee
approved these changes
Sep 25, 2024
PrathibaJee
suggested changes
Sep 25, 2024
| * no response value expected for this operation | ||
| **/ | ||
| exports.registerYourself = async function (body, user, xCorrelator, traceIndicator, customerJourney, operationServerName) { | ||
| exports.registerYourself = async function (body, user, xCorrelator, traceIndicator, customerJourney, operationServerName, forwardingName = undefined) { |
Contributor
There was a problem hiding this comment.
variable name shall be more specific like "beaqueathYourDataAndDieForwardingName" instead of forwardingName.
Also include JSdoc describing the purpose of the newly introduced variable.
| if(forwardingName == undefined){ | ||
| beaqueathYourDataAndDieForwardingName = "PromptForEmbeddingCausesRequestForBequeathingData"; | ||
| }else{ | ||
| beaqueathYourDataAndDieForwardingName = "PromptForEmbeddingInitiatesEmbeddingProcess.RequestForBequeathingData" |
Contributor
There was a problem hiding this comment.
if forwardingName is not undefined , then you have to assign the incoming "forwardingName" , not again hardcoding another forwarding name here.
IswaryaaS
approved these changes
Oct 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
#1015
#1017
Reviewer @PrathibaJee