Resolve Check /core-model-1-4:control-construct testcases should avoi…#909
Merged
Conversation
…d check of operation key Fixes #837
IswaryaaS
suggested changes
Nov 2, 2023
Contributor
There was a problem hiding this comment.
The solution looks very good . PLease find few comments below:
- Indent the file as discussed
- Update the function name in catch block to the expected function name
- Update the function name , it could be updated to RemoveOperationKeyAttributeFromLtp().
- layer-protocol need not be iterated (just to avoid complexity)
Collaborator
Author
|
done |
IswaryaaS
suggested changes
Nov 3, 2023
Contributor
IswaryaaS
left a comment
IswaryaaS
left a comment
There was a problem hiding this comment.
Few more comments:
- variables shall be named in lower camel case (operationClientInterfacePac)
- variables shall be declared with "let" keyword . Here, serverclientinterfacepac is missed for declaring
IswaryaaS
suggested changes
Nov 3, 2023
Contributor
IswaryaaS
left a comment
IswaryaaS
left a comment
There was a problem hiding this comment.
- /v1/register-yourself :: Attribute configured? :: https attributes updated? :: https-address/ipv-4-address updated? , https-port updated? and domain-name updated? - kindly update the changes in these files
- /v1/embed-yourself :: Update LTP notified? :: registry-office-port update, old-release-protocol update - kindly update the changes in these files
IswaryaaS
approved these changes
Nov 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…d check of operation key
Fixes #837