Services Vs Function - Same repository?

[latta-siae]

According with new way of implementation, it has been requested to decoupling functions from Services.

I'm asking if the git repository it will be the same for both the development. If yes I can see some problem managing different branches.
Maybe you can clarify

[openBackhaul]

We discussed internally and agreed on implementing the genericFunctions in the same repository as the rest of the application.
Conflicts between parallel implementation teams shall be excluded by defining code ownership on separated folders.
The following folder structure has been prepared:

[latta-siae]

Hi @openBackhaul,
Actually in the meeting if I remember well, I disagree on this way of proceed, and any decision was taken.
Sorry but I wasn't ready for a proposal.

My concern is not about code ownership but about the release management.
If we are taking the develop branch as source of truth, my expectation would be a stream of implementation of the same things.

So if you want decoupling those general functions from specific module (like DPMDP) I would suggest to spill over general function from this repository and manage it separately.
In this way there is more freedom to manage Common functions as separate library without been nested into the services module. Moreover newer version of common functions can be developed without disrupting other activities on DPMDP

This could be a scenario:
Team A is developing a new feature on DPMDP, so ready to merge into mainline
Team B is managing common functions, and it has to a reverse merging due to a regression.
That would cause a conflict and develop branch will be crowdy to mange

That is my humble opinion, all the effort to think about decoupling will be vanishing due to monorepo choice.
Please spent some minutes to consider pros and cos to have a single repo and take in account those side effects.

Thanks in advance
Lorenzo

[openBackhaul]

Hi @latta-siae,
Please excuse my imprecise wording.
By “discussed internally,” I meant a separate meeting with members of the MW SDN engineering team.

We came to the conclusion that changes to the genericFunctions will not get in conflict with changes to the DPMDP as the server folder will not directly use the generic functions - it will only use the npm packages generated from them.

Anyway, I am open to optimization. So, I keep the issue open for further discussions.