Import task: Handle exercises without tests / model solution files

[MrSerth]

When importing a ProFormA task that contains a test but without a test file or alternatively a model solution without a model solution file, CodeOcean throws an error.

Most likely, the error is caused through these two lines:

codeocean/app/services/proforma_service/convert_task_to_exercise.rb

Line 68 in 1e08f2c

task_files.delete(test_object.files.first.id).tap do |file|

codeocean/app/services/proforma_service/convert_task_to_exercise.rb

Line 79 in 1e08f2c

task_files.delete(model_solution_object.files.first.id).tap do |file|

Here, we are accessing the ID of the first file for both, but don't handle the case where no file exists.

[kkoehn]

A model-solution without files is not allowed by the schema and importing tests without files does not error anymore (there were some refactors in the meantime).

[MrSerth]

... importing tests without files does not error anymore

For me, it still errors with 03c71f4 and openHPI/codeharbor@0863898. Here is an example I've exported from CodeHarbor: task_898.zip

[kkoehn]

The problem with the mentioned task is a missing description, which is validated for presence by CO. The validation could be conditionalized like for execution_environment to make the import more robust.

[MrSerth]

The problem with the mentioned task is a missing description, which is validated for presence by CO. The validation could be conditionalized like for execution_environment to make the import more robust.

Ah, right! I double-checked, and having a validation is enough to perform the import successfully. Then, yes, a more robust import would be great. I would also be fine to add a description (like the title) if missing. 😇

[MrSerth]

@kkoehn Feel free to set the description to the same value as the title (if the description is otherwise blank) and close this issue. Thanks!

[kkoehn]

I added that in #2867

[MrSerth]

Awesome, thank you! I am confident that the PR #2867 will fix the issue (based on a short glimpse at the code), so that we can close it once merged.