WEB-795 Fix the Loan Information section - #3236
Merged
IOhacker merged 1 commit intoFeb 27, 2026
Merged
Conversation
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (16)
Note
|
| Cohort / File(s) | Summary |
|---|---|
Loans view UI src/app/loans/loans-view/loans-view.component.html, src/app/loans/loans-view/loans-view.component.scss, src/app/loans/loans-view/loans-view.component.ts |
Replaced inline h3 header with a loan-information-table (account-overview) showing status, product name, loan id, external id (conditional), and client info; added .loan-information-table CSS rules; imported ExternalIdentifierComponent into the component imports. |
Translation files src/assets/translations/cs-CS.json, de-DE.json, en-US.json, es-CL.json, es-MX.json, fr-FR.json, it-IT.json, ko-KO.json, lt-LT.json, lv-LV.json, ne-NE.json, pt-PT.json, sw-SW.json |
Added "Loan Account Status" key to many locales; es-MX and pt-PT also add "Loan Amount and Balance"; minor ordering/blank-line edits in sw-SW.json. |
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~20 minutes
Possibly related PRs
- WEB-634 The dashboard menu should display the full credit traceability. #3078: Modifies the loans-view component and UI layout; likely related to the same account header area.
- WEB-689: Fix Spanish Translation #3121: Edits Spanish translation files (
es-CL,es-MX), overlapping translation changes present here.
Suggested reviewers
- IOhacker
- alberto-art3ch
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
| Check name | Status | Explanation |
|---|---|---|
| Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | ✅ Passed | The title clearly relates to the main change: reorganizing the Loan Information section from inline presentation to a structured table layout with updated translations across multiple locales. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
🧪 Generate unit tests (beta)
- Create PR with unit tests
- Post copyable unit tests in a comment
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands and usage tips.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/app/loans/loans-view/loans-view.component.html`:
- Around line 46-63: The template uses string attribute bindings (e.g.,
completed="true" and externalId="{{ loanDetailsData.externalId }}") which breaks
type safety; update the mifosx-external-identifier component to use property
bindings: bind externalId and completed as properties (e.g.,
[externalId]="loanDetailsData.externalId" and [completed]="true") and, for
consistency and type safety, convert other interpolated inputs in this snippet
(mifosx-long-text.textValue and mifosx-account-number.accountNo) to property
bindings ([textValue]="loanDetailsData.loanProductName" and
[accountNo]="loanDetailsData.accountNo"). Ensure you modify the
mifosx-external-identifier, mifosx-long-text, and mifosx-account-number usages
accordingly.
In `@src/assets/translations/es-CL.json`:
- Around line 1379-1381: The inputs object in the Spanish Chile locale is
missing the "External Loan ID" translation key used by the updated loans view;
add an "External Loan ID" entry inside the "inputs" object (next to "Loan
Account Status" and "Floating rate") with an appropriate Spanish translation
(e.g., "ID de préstamo externo") so the UI uses the localized string instead of
falling back to the raw key.
ℹ️ Review info
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (16)
src/app/loans/loans-view/loans-view.component.htmlsrc/app/loans/loans-view/loans-view.component.scsssrc/app/loans/loans-view/loans-view.component.tssrc/assets/translations/cs-CS.jsonsrc/assets/translations/de-DE.jsonsrc/assets/translations/en-US.jsonsrc/assets/translations/es-CL.jsonsrc/assets/translations/es-MX.jsonsrc/assets/translations/fr-FR.jsonsrc/assets/translations/it-IT.jsonsrc/assets/translations/ko-KO.jsonsrc/assets/translations/lt-LT.jsonsrc/assets/translations/lv-LV.jsonsrc/assets/translations/ne-NE.jsonsrc/assets/translations/pt-PT.jsonsrc/assets/translations/sw-SW.json
JaySoni1
force-pushed
the
WEB-795-fix-the-loan-information-section
branch
from
February 26, 2026 23:49
3468723 to
8901f7b
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/assets/translations/cs-CS.json`:
- Line 1379: Update the Czech translation for the key "Loan Account Status" in
src/assets/translations/cs-CS.json to use a more precise account-level term by
replacing "Stav půjčky" with "Stav úvěrového účtu"; locate the JSON entry with
the key "Loan Account Status" and update its value accordingly, preserving JSON
formatting and escaping rules.
ℹ️ Review info
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (16)
src/app/loans/loans-view/loans-view.component.htmlsrc/app/loans/loans-view/loans-view.component.scsssrc/app/loans/loans-view/loans-view.component.tssrc/assets/translations/cs-CS.jsonsrc/assets/translations/de-DE.jsonsrc/assets/translations/en-US.jsonsrc/assets/translations/es-CL.jsonsrc/assets/translations/es-MX.jsonsrc/assets/translations/fr-FR.jsonsrc/assets/translations/it-IT.jsonsrc/assets/translations/ko-KO.jsonsrc/assets/translations/lt-LT.jsonsrc/assets/translations/lv-LV.jsonsrc/assets/translations/ne-NE.jsonsrc/assets/translations/pt-PT.jsonsrc/assets/translations/sw-SW.json
🚧 Files skipped from review as they are similar to previous changes (10)
- src/app/loans/loans-view/loans-view.component.scss
- src/assets/translations/en-US.json
- src/app/loans/loans-view/loans-view.component.html
- src/assets/translations/ko-KO.json
- src/assets/translations/es-MX.json
- src/assets/translations/ne-NE.json
- src/assets/translations/fr-FR.json
- src/assets/translations/es-CL.json
- src/assets/translations/lt-LT.json
- src/assets/translations/lv-LV.json
JaySoni1
force-pushed
the
WEB-795-fix-the-loan-information-section
branch
from
February 27, 2026 00:01
8901f7b to
5690bff
Compare
Contributor
Author
|
@IOhacker Thank You for the review |
This was referenced Mar 13, 2026
2 tasks
2 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chnages Made :-
-Update Loan Information section .
WEB-795
Before :-
After :-
Summary by CodeRabbit
New Features
Localization
Style