WEB-222: Family Members in Create Client stepper preview page not rendered correctly. - #3276
Merged
Merged
Conversation
|
Note
|
| Cohort / File(s) | Summary |
|---|---|
Layout Styling src/app/clients/client-stepper/client-preview-step/client-preview-step.component.html |
Updated container div CSS classes in the Family Members section from layout-row-wrap responsive-column flex-fill to layout-column flex-100, changing layout behavior from row-wrap to column with adjusted flex properties. |
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~3 minutes
Suggested reviewers
- IOhacker
- alberto-art3ch
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
| Check name | Status | Explanation |
|---|---|---|
| Title check | ✅ Passed | The title clearly identifies the bug fix (Family Members rendering issue) and the specific location (Create Client stepper preview page), directly matching the core change in the HTML layout classes. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
| Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. |
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
🧪 Generate unit tests (beta)
- Create PR with unit tests
- Post copyable unit tests in a comment
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands and usage tips.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a layout regression introduced during the Angular 14 to 19 update. When creating a new client and adding family members, the preview page was rendering the family members section too far on the right instead of displaying it as a left-aligned list below the general information.
The fix changes the CSS class on the family members wrapper div from
layout-row-wrap responsive-column flex-fill m-b-20tolayout-column flex-100 m-b-20. Thelayout-row-wrapclass was causing the heading, divider, and accordion to be laid out as horizontal flex items in a row. The newlayout-columnclass ensures the children stack vertically (column direction), andflex-100ensures the section takes full width and is left-aligned.No new dependencies are required for this change.
Related issues and discussion
#WEB-222
After Video:
Clients.-.Google.Chrome.2026-03-03.16-19-05.mp4
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
If you have multiple commits please combine them into one commit by squashing them.
Read and understood the contribution guidelines at
web-app/.github/CONTRIBUTING.md.