WEB-902 Page title for loan accounts displays generic general instead of loan account details - #3465
Merged
Conversation
|
Note
|
| Cohort / File(s) | Summary |
|---|---|
Routing Module Update src/app/loans/loans-routing.module.ts |
Updated child route :loanId -> general data.title from "General" to "Loan Account Details"; breadcrumb and routeParamBreadcrumb unchanged. |
Translation Files src/assets/translations/cs-CS.json, src/assets/translations/de-DE.json, src/assets/translations/en-US.json, src/assets/translations/es-CL.json, src/assets/translations/es-MX.json, src/assets/translations/fr-FR.json, src/assets/translations/it-IT.json, src/assets/translations/ko-KO.json, src/assets/translations/lt-LT.json, src/assets/translations/lv-LV.json, src/assets/translations/ne-NE.json, src/assets/translations/pt-PT.json, src/assets/translations/sw-SW.json |
Added translation key "Loan Account Details" with localized values in each file; no other keys modified. |
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~3 minutes
Possibly related PRs
- WEB-634 The dashboard menu should display the full credit traceability. #3078: Also modifies
src/app/loans/loans-routing.module.ts(adds/adjusts loan child routes), closely related to this route metadata change.
Suggested reviewers
- IOhacker
- alberto-art3ch
- gkbishnoi07
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
| Check name | Status | Explanation |
|---|---|---|
| Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | ✅ Passed | The PR title accurately describes the main change: updating the loan account page title from a generic 'General' to 'Loan Account Details' across routing and all supported locales. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
🧪 Generate unit tests (beta)
- Create PR with unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands and usage tips.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/assets/translations/es-CL.json`:
- Line 3406: Update the translation value for the key "Loan Account Details" to
use the project-consistent Spanish term "Crédito" instead of "préstamo" (e.g.,
change "Detalles de la cuenta de préstamo" to "Detalles de la cuenta de Crédito"
or to the established casing used elsewhere) so the UI wording matches other
translations that use "Crédito".
In `@src/assets/translations/it-IT.json`:
- Line 3403: Replace the value for the translation key "Loan Account Details" so
it uses the standard Italian phrasing used elsewhere ("conto di prestito");
update the JSON entry for the "Loan Account Details" key from "Dettagli del
conto prestito" to "Dettagli del conto di prestito" to match existing locale
terminology and keep UI copy consistent.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: f81db5b1-f495-497f-b289-200cf5b147c8
📒 Files selected for processing (14)
src/app/loans/loans-routing.module.tssrc/assets/translations/cs-CS.jsonsrc/assets/translations/de-DE.jsonsrc/assets/translations/en-US.jsonsrc/assets/translations/es-CL.jsonsrc/assets/translations/es-MX.jsonsrc/assets/translations/fr-FR.jsonsrc/assets/translations/it-IT.jsonsrc/assets/translations/ko-KO.jsonsrc/assets/translations/lt-LT.jsonsrc/assets/translations/lv-LV.jsonsrc/assets/translations/ne-NE.jsonsrc/assets/translations/pt-PT.jsonsrc/assets/translations/sw-SW.json
… of Loan Account Details
JaySoni1
force-pushed
the
WEB-902-page-title-for-loan-accounts-displays-generic-general-instead-of-loan-account-details
branch
from
April 5, 2026 01:11
53e36ba to
d590461
Compare
devvaansh
reviewed
Apr 5, 2026
| path: 'general', | ||
| component: GeneralTabComponent, | ||
| data: { title: 'General', breadcrumb: 'General', routeParamBreadcrumb: false }, | ||
| data: { title: 'Loan Account Details', breadcrumb: 'General', routeParamBreadcrumb: false }, |
Member
There was a problem hiding this comment.
while the page title is now updated, will the breadcrumb still display 'General'?
Contributor
Author
There was a problem hiding this comment.
@devvaansh On the Client page, the breadcrumb will display “General,” while on the Loan Account page, the browser tab will show “Loan Account Details.”
devvaansh
reviewed
Apr 5, 2026
devvaansh
left a comment
devvaansh
left a comment
Member
There was a problem hiding this comment.
Great work on the translations and title update. One quick observation
Contributor
Author
|
@IOhacker Thank You for the review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Made :-
-Updates the route configuration in loans-routing.module.ts for the general tab, changing the title data property from 'General' to 'Loan Account Details'.
-Injects the new translation mapping for "Loan Account Details" into en-US.json and all 12 supported non-English locale JSON files.
WEB-902
Before :-
After :-
Summary by CodeRabbit
New Features
Documentation