WEB-1104: Hide Close action for already-closed clients

[Farah-Nahle-FOO]

Description

Hid the Close action from the client Header Actions menu once a client's status is already Closed. Previously the menu item was rendered unconditionally, so it stayed visible after closure; clicking it opened the Close form and submission then failed with a server-side "client is already closed" error. The fix gates the button on clientViewData.status.value === 'Active', mirroring the existing pattern already used for Reactivate/Activate/Reject in the same menu. No new dependencies.

Related issues and discussion

WEB-1104

Screenshots, if any

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

• If you have multiple commits please combine them into one commit by squashing them.

• Read and understood the contribution guidelines at web-app/.github/CONTRIBUTING.md.

Summary by CodeRabbit

• Bug Fixes
  • The “Close” action is now shown only for clients with an Active status.

[coderabbitai]

Note

.coderabbit.yaml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)

Validation error: Unrecognized key: "pre_merge_checks"

⚙️ Configuration instructions

• Please see the configuration documentation for more information.
• You can also validate your configuration using the online YAML validator.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 0283c953-8842-490f-8d20-8874516e3ebc

📥 Commits

Reviewing files that changed from the base of the PR and between ae1cadc and 0f63e01.

📒 Files selected for processing (1)

• src/app/clients/clients-view/clients-view.component.html

---

Walkthrough

The client view now displays the “Close” action only when clientViewData.status.value is Active. Its click behavior and label remain unchanged.

Changes

Client Close Action

Layer / File(s)	Summary
Active status visibility src/app/clients/clients-view/clients-view.component.html	The Close action is wrapped in an @if condition that checks for Active status.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: alberto-art3ch

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the main change: hiding the Close action for clients that are already closed.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}