- set pointers to 0 after delete to have reliable errors

openSUSE · aschnell · Jul 24, 2018 · Jul 23, 2018 · Jul 23, 2018 · Jul 23, 2018
commit 4434ecb84eea12f553b495e6004a44b93fdd3303
diff --git a/server/Client.cc b/server/Client.cc
@@ -113,6 +113,7 @@ Client::delete_comparison(list<Comparison*>::iterator it)
     }
 
     delete *it;
+    *it = nullptr;
 }
 
 

diff --git a/server/MetaSnapper.cc b/server/MetaSnapper.cc
@@ -1,5 +1,6 @@
 /*
  * Copyright (c) [2012-2015] Novell, Inc.
+ * Copyright (c) 2018 SUSE LLC
  *
  * All Rights Reserved.
  *
@@ -103,6 +104,7 @@ MetaSnapper::MetaSnapper(ConfigInfo& config_info)
 MetaSnapper::~MetaSnapper()
 {
     delete snapper;
+    snapper = nullptr;
 }
 
 
@@ -172,7 +174,7 @@ void
 MetaSnapper::unload()
 {
     delete snapper;
-    snapper = NULL;
+    snapper = nullptr;
 }
 
 

diff --git a/snapper/Log.cc b/snapper/Log.cc
@@ -64,6 +64,7 @@ namespace snapper
     {
 	callLogDo(level, *component, file, line, func, stream->str());
 	delete stream;
+	stream = nullptr;
     }
 
 }
diff --git a/snapper/Snapper.cc b/snapper/Snapper.cc
@@ -1,6 +1,6 @@
 /*
  * Copyright (c) [2011-2015] Novell, Inc.
- * Copyright (c) 2016 SUSE LLC
+ * Copyright (c) [2016,2018] SUSE LLC
  *
  * All Rights Reserved.
  *
@@ -147,7 +147,10 @@ namespace snapper
 	}
 
 	delete filesystem;
+	filesystem = nullptr;
+
 	delete config_info;
+	config_info = nullptr;
     }
-Original file line number
+Diff line change
@@ Expand Up / @@ -113,6 +113,7 @@ Client::delete_comparison(list<Comparison*>::iterator it) @@
         }
         delete *it;
+        *it = nullptr;
     }
@@ Expand Down @@