feat: TestOpportunityBookableFreeCancellable and TestOpportunityBookableNonFreeCancellable#18
Open
nickevansuk wants to merge 1 commit into
Open
feat: TestOpportunityBookableFreeCancellable and TestOpportunityBookableNonFreeCancellable#18nickevansuk wants to merge 1 commit into
TestOpportunityBookableFreeCancellable and TestOpportunityBookableNonFreeCancellable#18nickevansuk wants to merge 1 commit into
Conversation
…okableNonFreeCancellable`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the test interface only includes
TestOpportunityBookableCancellable, which randomly selects between free and non-free opportunities.Many booking systems execute different business logic when cancelling a free vs a non-free booking.
In order to allow the test suite to consistently execute the business logic for both free and non-free cancellation scenarios, additional criteria
TestOpportunityBookableFreeCancellableandTestOpportunityBookableNonFreeCancellablemust be introduced.This enables the implementation of openactive/openactive-test-suite#548 at a later date.