-
Notifications
You must be signed in to change notification settings - Fork 12.8k
core: refresh developer instructions after compaction replacement history #10574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
706b03d
core: refresh developer instructions after compaction replacement his…
charley-oai 72bf70c
Use shared process_compacted_history path and add e2e coverage
charley-oai ff80829
Strip turn_aborted markers during compaction
charley-oai d6449e3
Bound reinjected turn context in compacted history
charley-oai 7db7fbe
Document reinjected turn-context budget rationale
charley-oai 88eb686
Insert reinjected turn context before final user message
charley-oai 26273ad
Update reconstruct-history expectation for context reinjection order
charley-oai 592feb0
Add non-resume remote compact stale-instructions regression test
charley-oai 4868ee7
nit
charley-oai 5c50dd2
Revert initial context trimming during compaction
charley-oai c155f9c
Insert turn context before last real user message
charley-oai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can initial_context be strictly prepended?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok spoke with Hanson and he recommended the following post-compaction layout: