feat: fork thread multi agent#12499
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c449d6b8cf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Security Review
Here are some automated security review suggestions for this pull request.
Reviewed commit: c449d6b8cf
ℹ️ About Codex security reviews in GitHub
This is an experimental Codex feature. Security reviews are triggered when:
- You comment "@codex security review"
- A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review
Once complete, Codex will leave suggestions, or a comment if no findings are found.
# Conflicts: # codex-rs/core/src/tools/handlers/multi_agents.rs
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 435ca4e8a9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| .ok_or_else(|| { | ||
| CodexErr::Fatal(format!( | ||
| "parent thread rollout unavailable for fork: {parent_thread_id}" | ||
| )) | ||
| })?; |
There was a problem hiding this comment.
Do not hard-fail forking when no rollout path exists. In ephemeral sessions, Codex::spawn does not create a rollout recorder/path, so this branch returns parent thread rollout unavailable for fork and spawn_agent with fork_mode=true always fails. That contradicts the tool behavior of forking current context and breaks multi-agent fork in ephemeral mode.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
I think this is actually preferable. We don't want the model to "think" the context has been forked while it has not
There was a problem hiding this comment.
💡 Codex Security Review
Here are some automated security review suggestions for this pull request.
Reviewed commit: 435ca4e8a9
ℹ️ About Codex security reviews in GitHub
This is an experimental Codex feature. Security reviews are triggered when:
- You comment "@codex security review"
- A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review
Once complete, Codex will leave suggestions, or a comment if no findings are found.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d4e1d38006
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| .ok_or_else(|| { | ||
| CodexErr::Fatal(format!( | ||
| "parent thread rollout unavailable for fork: {parent_thread_id}" | ||
| )) | ||
| })?; |
There was a problem hiding this comment.
Forking hard-requires a rollout file path and returns parent thread rollout unavailable... when none is found. In ephemeral sessions, threads have no rollout file, so fork_mode=true will always fail even though parent history exists in memory. This breaks fork-mode behavior for active ephemeral threads.
Useful? React with 👍 / 👎.
charley-oai
left a comment
charley-oai
left a comment
There was a problem hiding this comment.
Nice. Left some nits
# Conflicts: # codex-rs/core/src/agent/control.rs
2 participants
No description provided.