[codex] Improve hook status rendering#17266
Conversation
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 22490e9ba5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2a8e2ae1be
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
fcoury-oai
left a comment
There was a problem hiding this comment.
The code looks good, I was able to test it and it works great, aside from one finding below and the one that Codex already pin pointed.
fcoury-oai
left a comment
There was a problem hiding this comment.
Looks good! Approved.
Motivation
Make hook display less noisy and more useful by keeping transient hook activity out of permanent history unless there is useful output
Also addresses some of the concerns in #15497
Changes
Hook Lifecycle Rendering
Running PreToolUse hook.Hook Reveal Timing
Running hookrow before user can read it every time.Completed Hook Output
• SessionStart hook (completed).warning:,stop:,feedback:,hook context:, anderror:.• PreToolUse hook (blocked)followed byfeedback: ....• PostToolUse hook (failed)followed byerror: ....Parallel Hook Behavior
• Running 3 PreToolUse hooks: checking command policy.Hook Run Identity
PreToolUseandPostToolUsehook run IDs now include the tool call ID which prevents concurrent tool-use hooks from sharing a run ID and clobbering each other in the UI.App-Server Hook Notifications
HookStartedandHookCompletednotifications use the same live hook rendering path as core hook events.UserPromptSubmithook notifications now render through the same completed hook output format, including warning and stop entries.