Skip to content

rollout-trace: record permission profiles #20436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bolinfest wants to merge 1 commit into from
Closed

rollout-trace: record permission profiles #20436

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion codex-rs/core/src/session/session.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -526,7 +526,7 @@ impl Session {
model: session_configuration.collaboration_mode.model().to_string(),
provider_name: config.model_provider_id.clone(),
approval_policy: session_configuration.approval_policy.value().to_string(),
sandbox_policy: format!("{:?}", session_configuration.sandbox_policy()),
permission_profile: format!("{:?}", session_configuration.permission_profile()),
};
let rollout_thread_trace = if matches!(
session_configuration.session_source,
Expand Down
2 changes: 1 addition & 1 deletion codex-rs/core/src/tools/tool_dispatch_trace_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ fn attach_test_trace(session: &mut Session, turn: &TurnContext, root: &Path) ->
model: "gpt-test".to_string(),
provider_name: "test-provider".to_string(),
approval_policy: "never".to_string(),
sandbox_policy: "danger-full-access".to_string(),
permission_profile: "Disabled".to_string(),
},
)?;
rollout_thread_trace.record_codex_turn_started(turn.sub_id.as_str());
Expand Down
2 changes: 1 addition & 1 deletion codex-rs/rollout-trace/src/thread.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ pub struct ThreadStartedTraceMetadata {
pub model: String,
pub provider_name: String,
pub approval_policy: String,
pub sandbox_policy: String,
pub permission_profile: String,
}

/// Trace-only payload for a child completion notification delivered to its parent.
Expand Down
6 changes: 3 additions & 3 deletions codex-rs/rollout-trace/src/thread_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ fn create_in_root_writes_replayable_lifecycle_events() -> anyhow::Result<()> {
model: "gpt-test".to_string(),
provider_name: "test-provider".to_string(),
approval_policy: "never".to_string(),
sandbox_policy: "DangerFullAccess".to_string(),
permission_profile: "Disabled".to_string(),
},
)?;

Expand Down Expand Up @@ -84,7 +84,7 @@ fn spawned_thread_start_appends_to_root_bundle() -> anyhow::Result<()> {
model: "gpt-test".to_string(),
provider_name: "test-provider".to_string(),
approval_policy: "never".to_string(),
sandbox_policy: "DangerFullAccess".to_string(),
permission_profile: "Disabled".to_string(),
});
child_trace.record_ended(RolloutStatus::Completed);
let bundle_dir = single_bundle_dir(temp.path())?;
Expand Down Expand Up @@ -201,7 +201,7 @@ fn minimal_metadata(thread_id: ThreadId) -> ThreadStartedTraceMetadata {
model: "gpt-test".to_string(),
provider_name: "test-provider".to_string(),
approval_policy: "never".to_string(),
sandbox_policy: "danger-full-access".to_string(),
permission_profile: "Disabled".to_string(),
}
}

Expand Down
Loading