TUI config cleanup: MCP inventory#24265
Merged
Merged
Conversation
etraut-openai
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
etraut-openai
changed the title
This was referenced May 24, 2026
fcoury-oai
approved these changes
May 25, 2026
Contributor
fcoury-oai
left a comment
fcoury-oai
left a comment
There was a problem hiding this comment.
Smoke tested and code looks good 👍
fcoury-oai
approved these changes
May 25, 2026
Contributor
fcoury-oai
left a comment
fcoury-oai
left a comment
There was a problem hiding this comment.
Tested and code looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The TUI
/mcpinventory flow should reflect the app server’s MCP status response. It was also joining those results with the TUI process’s localconfig.mcp_servers, which can diverge once MCP state is owned by a remote app server and cause stale local command, URL, status, or empty-state details to render.This change removes the local config join from the app-server-backed inventory renderer. The TUI now renders directly from the existing
mcpServerStatus/listpayload and treats an empty status response as the empty MCP inventory state.Known limitation
The existing
mcpServerStatus/listpayload does not include disabled-state or disabled-reason fields. To preserve the current app-server API, this PR does not try to infer that state from client-local config. If remote/mcpneeds to show disabled/reason details again, that should come from app-server-owned status data in a follow-up.Related to #22914, #22915, and #22916.