fix(tui): improve multiline markdown list readability#24351
Merged
Conversation
etraut-openai
approved these changes
May 25, 2026
Collaborator
etraut-openai
left a comment
There was a problem hiding this comment.
Looks good. I especially like the color treatment on the numbers.
My only (small) concern is about copy behavior, but that was already a problem prior to this change because of the leading two spaces. This adds more spaces.
The code looks good.
I manually verified the fix and confirmed that formatting looks good and it reflows correctly when resizing the terminal.
Contributor
Author
Agreed, I will see if there's something we can do when falling back to raw mode in that regard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Numbered Markdown findings become hard to scan when long items visually run together or when wrapped explanatory paragraphs lose their list indentation. This is especially visible in review output: the next number can look attached to the previous finding, and paragraph continuation rows can jump back toward the left margin instead of staying grouped beneath their item.
What Changed
How to Test
019e563f-7d58-7ff2-8ec7-828f20fa61ca.Findingslist whose items contain explanatory paragraphs.Targeted tests:
just test -p codex-tui history_cell insert_history markdown_render markdown_stream streaming::controllerjust argument-comment-lint-from-source -p codex-tuiRelated Work
PR #24346 changes Markdown table column allocation in parallel. This PR is intentionally limited to list-item readability and history wrapping; both branches touch
codex-rs/tui/src/markdown_render.rs, so a small merge conflict may need resolution depending on merge order.