Render multiline hook output in TUI#24965
Merged
Merged
Conversation
fcoury-oai
approved these changes
May 29, 2026
Contributor
fcoury-oai
left a comment
There was a problem hiding this comment.
Smoke tested and works as expected, good looks good! 👍
Approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Fixes #24529. Completed hook output in the TUI rendered each
HookOutputEntryas one ratatui line, so explicit newlines inside hook output were not shown as separate transcript rows. That made multilineSessionStart.additionalContexthard to inspect even though the model-facing context path preserved the original text.What
codex-rs/tui/src/history_cell/hook_cell.rs.hook context:orwarning:, on the first physical line only.SessionStarthistory output.Testing
cargo nextest run -p codex-tui completed_hook_multiline hook_completed_before_reveal_renders_completed_without_running_flashjust argument-comment-lint -p codex-tui -- --ignore-rust-version --lib --tests