Skip to content

[codex] Require model for standalone web search#25131

Merged
sayan-oai merged 1 commit into
mainfrom
codex/standalone-web-search-model
May 29, 2026
Merged

[codex] Require model for standalone web search#25131
sayan-oai merged 1 commit into
mainfrom
codex/standalone-web-search-model

Conversation

@sayan-oai
Copy link
Copy Markdown
Collaborator

@sayan-oai sayan-oai commented May 29, 2026

Why

The standalone /v1/alpha/search request now requires a model, but the web.run extension currently omits it.

Adds model to extension ToolCall invocation.

Follow-up to #23823.

What changed

  • Make SearchRequest.model required.
  • Expose the effective per-turn model on extension tool calls and pass it in standalone web-search requests.
  • Assert the model is forwarded in the app-server round-trip test.

Testing

  • just test -p codex-api -p codex-tools -p codex-web-search-extension -p codex-memories-extension -p codex-goal-extension
  • just test -p codex-core -E 'test(passes_turn_fields_and_scoped_turn_item_emitter_to_extension_call)'
  • just test -p codex-app-server -E 'test(standalone_web_search_round_trips_encrypted_output)'

@sayan-oai sayan-oai marked this pull request as ready for review May 29, 2026 18:33
@sayan-oai sayan-oai requested a review from a team as a code owner May 29, 2026 18:33
Copy link
Copy Markdown
Collaborator

@jif-oai jif-oai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sense

@sayan-oai sayan-oai merged commit 1f93706 into main May 29, 2026
31 checks passed
@sayan-oai sayan-oai deleted the codex/standalone-web-search-model branch May 29, 2026 19:03
@github-actions github-actions Bot locked and limited conversation to collaborators May 29, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants