fix: Bedrock API key region fallback#25171
Merged
Merged
Conversation
celia-oai
force-pushed
the
dev/cc/region-fix
branch
from
c61ca72 to
04bc2fe
Compare
celia-oai
force-pushed
the
dev/cc/region-fix
branch
from
04bc2fe to
caa27e8
Compare
Collaborator
Author
|
@codex review |
Contributor
|
Codex Review: Didn't find any major issues. What shall we delve into next? ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
owenlin0
reviewed
May 29, 2026
owenlin0
approved these changes
May 29, 2026
Collaborator
owenlin0
left a comment
owenlin0
left a comment
There was a problem hiding this comment.
nit about tests, but logic lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Users following the Amazon Bedrock API-key setup can export
AWS_BEARER_TOKEN_BEDROCKandAWS_REGION, but Codex's bearer-token auth path only acceptedmodel_providers.amazon-bedrock.aws.region. That made the documented env-based setup fail with a missing-region error even though the standard AWS region environment variable was present.What Changed
model_providers.amazon-bedrock.aws.regionfirst, then fall back toAWS_REGION, thenAWS_DEFAULT_REGION.AWS_REGION,AWS_DEFAULT_REGION, and the missing-region failure.