[codex] Update remote connector suggestions#25172
Merged
Merged
Conversation
xl-openai
reviewed
May 29, 2026
xl-openai
approved these changes
May 29, 2026
sayan-oai
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tool_suggest_connector_ids().Context
Loaded remote plugins can declare app connector IDs in
.app.json. The session-ownedPluginsManageralready loads those plugins and exposes their effective app IDs.The connector suggestion path was creating a separate
PluginsManagerand recomputing plugin app IDs. That new manager does not share the session manager’s remote installed plugin cache, so app IDs from loaded remote plugins were missing from connector suggestions.Fix
Pass the already-loaded effective app IDs into connector suggestion generation and use them directly as the plugin-derived connector candidate set.
Connector candidates are now built from:
This avoids a second plugin-manager lookup and keeps connector suggestions aligned with the plugins actually loaded for the turn.
Behavior
For example, when a plugin is loaded and its
.app.jsondeclares data apps,list_available_plugins_to_installcan now return those data connectors.This does not create plugin suggestions from the plugin itself. Plugin suggestions still come from eligible uninstalled entries in the marketplace catalog and require existing matching/filtering rules.
Validation
just fmtjust test -p codex-core; the command exited unsuccessfully in the local test environment without useful failure detail captured in the run output