exec-server: default remote transport to Noise#26245
Conversation
d9dcdd7 to
bf36de0
Compare
3155e3d to
75fd2a0
Compare
bf36de0 to
933e101
Compare
75fd2a0 to
1c43ca0
Compare
933e101 to
e8dc0ef
Compare
1c43ca0 to
ce56344
Compare
Co-authored-by: Codex noreply@openai.com
Co-authored-by: Codex noreply@openai.com
ce56344 to
a742187
Compare
68f52ab to
8a59e51
Compare
a742187 to
64fdb40
Compare
8a59e51 to
38c303e
Compare
Co-authored-by: Codex noreply@openai.com
64fdb40 to
d5c0763
Compare
38c303e to
4d7004b
Compare
d5c0763 to
e99601b
Compare
4d7004b to
265d057
Compare
e99601b to
7e49c03
Compare
265d057 to
4c9687b
Compare
7e49c03 to
040d711
Compare
Co-authored-by: Codex noreply@openai.com
Co-authored-by: Codex noreply@openai.com
Co-authored-by: Codex noreply@openai.com
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c51c634ba8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-authored-by: Codex noreply@openai.com
Co-authored-by: Codex noreply@openai.com
Co-authored-by: Codex noreply@openai.com
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2d3f9be4d2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-authored-by: Codex noreply@openai.com
…into codex/viyatb/noise-cli-entrypoint
Co-authored-by: Codex noreply@openai.com
Co-authored-by: Codex noreply@openai.com
…yatb/noise-cli-entrypoint
## Why Rendezvous forwards traffic between the orchestrator and exec-server. The endpoints need to authenticate each other and encrypt that traffic without trusting Rendezvous with plaintext or endpoint keys. ## Changes - Adds a hybrid Noise IK channel through Clatter using X25519, ML-KEM-768, AES-256-GCM, and SHA-256. - Binds each handshake to `environment_id`, `executor_registration_id`, and `stream_id`. - Pins the registry-provided executor key and carries the harness authorization inside the encrypted handshake. - Orders relay frames before consuming Noise nonces and fragments large JSON-RPC messages into bounded records. - Bounds handshake payloads, frames, streams, and message reassembly. Runtime activation is in [#26245](#26245). ## Stack 1. **[#26242](#26242: Noise channel and relay transport 2. [#26245](#26245): remote registration and runtime activation ## Verification - `just test -p codex-exec-server` - Oversized initiator payload regression coverage - `just fix -p codex-exec-server` - `just bazel-lock-check` - `cargo shear` --------- Co-authored-by: Codex <noreply@openai.com>
…i-entrypoint # Conflicts: # codex-rs/exec-server/src/noise_channel.rs # codex-rs/exec-server/src/noise_channel_tests.rs # codex-rs/exec-server/src/noise_relay/harness.rs # codex-rs/exec-server/src/noise_relay/mod.rs # codex-rs/exec-server/src/relay.rs
Co-authored-by: Codex noreply@openai.com
This reverts commit 59b780c.
Why
The transport in openai/codex#26242 needs to be used by every remote orchestrator-to-executor connection before JSON-RPC traffic starts.
Changes
Stack
Verification
just test -p codex-exec-serverjust fix -p codex-exec-serverjust bazel-lock-checkcargo shear