Skip to content

Make auto-review on-request prompt more proactive#26496

Merged
maja-openai merged 8 commits into
mainfrom
maja/change-on-request-auto-review-prompt
Jun 18, 2026
Merged

Make auto-review on-request prompt more proactive#26496
maja-openai merged 8 commits into
mainfrom
maja/change-on-request-auto-review-prompt

Conversation

@maja-openai

@maja-openai maja-openai commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Why

on-request approval policy text is currently tuned for user-reviewed approvals. For auto-reviewed productivity runs, likely sandbox blocks should be escalated earlier so commands that need remote services, authentication, or other out-of-sandbox access do not first fail or hang inside the sandbox.

What changed

  • Adds a separate on_request_auto_review.md permissions prompt selected for AskForApproval::OnRequest with ApprovalsReviewer::AutoReview.
  • Keeps the normal user-reviewed on-request wording unchanged.
  • Makes the When to request escalation bullets more explicit about likely sandbox blocks, network access, remote auth/cluster/cloud/database access, out-of-sandbox environment access, git operations that may write lock files, and short-timeout reruns after likely sandbox-blocked attempts.
  • Omits approved command prefix and prefix_rule guidance for the auto-review on-request prompt.
  • Adds prompt tests covering the auto-review path, normal on-request wording, and inline permission request behavior.

@maja-openai maja-openai marked this pull request as ready for review June 5, 2026 16:49
@maja-openai maja-openai requested a review from a team as a code owner June 5, 2026 16:49
@maja-openai maja-openai merged commit d9dace8 into main Jun 18, 2026
31 checks passed
@maja-openai maja-openai deleted the maja/change-on-request-auto-review-prompt branch June 18, 2026 20:16
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants