PAC 5 - Add network proxy system proxy routing#27248
Closed
canvrno-oai wants to merge 3 commits into
Closed
Conversation
canvrno-oai
force-pushed
the
canvnro/codex-pac-pr4-mac
branch
from
June 10, 2026 18:24
b9e4832 to
6158992
Compare
canvrno-oai
force-pushed
the
canvnro/codex-pac-pr5-network-proxy-pac
branch
from
June 10, 2026 18:24
6b58ee0 to
44a3c57
Compare
canvrno-oai
force-pushed
the
canvnro/codex-pac-pr4-mac
branch
from
June 10, 2026 20:42
6158992 to
e4b8b92
Compare
canvrno-oai
force-pushed
the
canvnro/codex-pac-pr5-network-proxy-pac
branch
from
June 10, 2026 20:42
44a3c57 to
01d6011
Compare
canvrno-oai
force-pushed
the
canvnro/codex-pac-pr4-mac
branch
from
June 11, 2026 19:14
e4b8b92 to
93e4e84
Compare
canvrno-oai
force-pushed
the
canvnro/codex-pac-pr5-network-proxy-pac
branch
from
June 11, 2026 19:14
01d6011 to
d37008e
Compare
canvrno-oai
force-pushed
the
canvnro/codex-pac-pr4-mac
branch
from
June 11, 2026 20:13
93e4e84 to
c91497e
Compare
canvrno-oai
force-pushed
the
canvnro/codex-pac-pr5-network-proxy-pac
branch
from
June 11, 2026 20:13
d37008e to
47a3c4c
Compare
viyatb-oai
reviewed
Jun 15, 2026
viyatb-oai
left a comment
Contributor
There was a problem hiding this comment.
One runtime responsiveness issue to address in the network-proxy integration.
canvrno-oai
force-pushed
the
canvnro/codex-pac-pr4-mac
branch
from
June 16, 2026 06:57
5dd8971 to
bc39031
Compare
canvrno-oai
force-pushed
the
canvnro/codex-pac-pr5-network-proxy-pac
branch
from
June 16, 2026 07:35
99a4b71 to
b36ead5
Compare
canvrno-oai
force-pushed
the
canvnro/codex-pac-pr4-mac
branch
from
June 16, 2026 16:44
bc39031 to
ab61237
Compare
canvrno-oai
force-pushed
the
canvnro/codex-pac-pr5-network-proxy-pac
branch
from
June 16, 2026 17:06
b36ead5 to
a55393f
Compare
canvrno-oai
force-pushed
the
canvnro/codex-pac-pr4-mac
branch
from
June 16, 2026 20:30
7354130 to
19ccecb
Compare
canvrno-oai
force-pushed
the
canvnro/codex-pac-pr5-network-proxy-pac
branch
from
June 16, 2026 20:31
a55393f to
582b5e0
Compare
canvrno-oai
force-pushed
the
canvnro/codex-pac-pr4-mac
branch
from
June 17, 2026 01:00
ac90f94 to
bf35429
Compare
canvrno-oai
force-pushed
the
canvnro/codex-pac-pr5-network-proxy-pac
branch
from
June 17, 2026 01:01
7581cbf to
c8dafdd
Compare
canvrno-oai
force-pushed
the
canvnro/codex-pac-pr4-mac
branch
from
June 17, 2026 18:52
bf35429 to
ac0677a
Compare
canvrno-oai
force-pushed
the
canvnro/codex-pac-pr5-network-proxy-pac
branch
from
June 17, 2026 18:53
c8dafdd to
529e393
Compare
canvrno-oai
force-pushed
the
canvnro/codex-pac-pr4-mac
branch
from
June 17, 2026 20:20
ac0677a to
9fb47f7
Compare
canvrno-oai
force-pushed
the
canvnro/codex-pac-pr5-network-proxy-pac
branch
from
June 17, 2026 20:20
529e393 to
b009471
Compare
canvrno-oai
force-pushed
the
canvnro/codex-pac-pr4-mac
branch
4 times, most recently
from
June 22, 2026 21:48
5b73387 to
4627c3e
Compare
canvrno-oai
force-pushed
the
canvnro/codex-pac-pr5-network-proxy-pac
branch
2 times, most recently
from
June 23, 2026 00:25
ac8a209 to
8261c5e
Compare
canvrno-oai
force-pushed
the
canvnro/codex-pac-pr5-network-proxy-pac
branch
from
June 23, 2026 00:59
8261c5e to
097602b
Compare
Contributor
|
Closing this pull request because it has had no updates for more than 14 days. If you plan to continue working on it, feel free to reopen or open a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
respect_system_proxyto sandboxed command egress throughnetwork-proxy.DIRECT.network-proxybehavior unchanged when the feature is disabled.Implementation
codex-client.respect_system_proxyinto thenetwork-proxyruntime configuration.Known limitation
Only the first supported system/PAC proxy candidate is used. A connection failure does not currently advance to subsequent proxy or
DIRECTcandidates. This matches the current native-client behavior and leaves ordered fallback support for a future improvement.Tests
just test -p codex-client -p codex-network-proxy(209 passed)just test -p codex-core --lib(1,893 passed; 3 skipped)just clippy -p codex-client -p codex-network-proxy -p codex-corejust fmtjust bazel-lock-check