Use generic search metadata for dynamic tools#27356
Merged
Merged
Conversation
sayan-oai
force-pushed
the
codex/dynamic-tools-generic-search-metadata
branch
from
June 11, 2026 04:16
520aff4 to
902b3a6
Compare
sayan-oai
marked this pull request as ready for review
June 11, 2026 05:38
pakrym-oai
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Dynamic tools maintained a separate search-text builder even though the shared tool search path already derives the same metadata from
ToolSpec. Using the shared path removes duplicate behavior before adding explicit namespaces.What changed
ToolSearchInfo::from_tool_spec.The old search text included the tool name, its space-separated form, description, namespace, and top-level parameter names. The shared builder preserves all of those terms and also indexes namespace descriptions and nested schema metadata.
Test plan
just test -p codex-core tool_search_returns_deferred_dynamic_tool_and_routes_follow_up_call