Support openai/form extended form elicitations#27500
Conversation
gpeal
changed the title
gpeal
force-pushed
the
gpeal/openai-form-app-server
branch
2 times, most recently
from
65a1e46 to
780037c
Compare
This reverts commit 442a648050ab3aef94afd819f02ad6a725c428d6.
gpeal
force-pushed
the
gpeal/openai-form-app-server
branch
from
780037c to
0e9a4ea
Compare
gpeal
changed the title
gpeal
changed the title
openai/form extended form elicitations
pakrym-oai
left a comment
pakrym-oai
left a comment
There was a problem hiding this comment.
The only blocking comments is please let's not store the setting in extension data and add more core (test_codex()) integration tests for new capability.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7dc91138b0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review this |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b1a2fb4d5f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ) | ||
| .await?; | ||
| existing_thread | ||
| .set_openai_form_elicitation_support(supports_openai_form_elicitation) |
There was a problem hiding this comment.
When a second connection resumes an already loaded thread, this overwrites the session-wide MCP capability with that connection's initialize bit. Because subsequent turn/start requests do not pass the caller's mcpServerOpenaiFormElicitation value, a non-supporting connection that resumes a shared thread leaves the next MCP refresh advertising no openai/form, even if the supporting client later starts the turn; the reverse can also leave the extension enabled for subscribers that never opted in. Keep this negotiation per connection/turn, or refresh it from the turn-starting connection before reconnecting MCP servers.
AGENTS.md reference: AGENTS.md:L103-L110
Useful? React with 👍 / 👎.
3 participants
Summary
Allow App Server clients to opt into
openai/formMCP elicitations.