[codex] Add auth mode to plugin manager constructor - #27652
Conversation
495f1f4 to
c9ab74c
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c9ab74cec3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
a6b6373 to
df88645
Compare
|
@codex review again |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
df88645 to
ba2f04d
Compare
490f500 to
57bc034
Compare
Context
Plugins can expose more than one way for Codex to use them: App connectors for ChatGPT/SIWC-backed sessions and MCP servers for API key login sessions. The broader goal is to make
PluginsManagerthe place that understands which plugin surfaces should be visible for the current auth route, so callers do not each have to make that decision themselves.This PR is the small setup step for that work. It lets the plugin manager be created with the current
AuthMode, which gives the followup auth routing PRs the information they need without relying on setter injection.Stack
Summary
PluginsManager::new_with_restriction_productaccept an initialAuthMode.PluginsManager::newbehavior unchanged for ordinary callers.Validation