Skip to content

[codex] Add auth mode to plugin manager constructor - #27652

Merged
xl-openai merged 2 commits into
mainfrom
plugin-auth-manager-constructor
Jun 13, 2026
Merged

[codex] Add auth mode to plugin manager constructor#27652
xl-openai merged 2 commits into
mainfrom
plugin-auth-manager-constructor

Conversation

@felixxia-oai

@felixxia-oai felixxia-oai commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Context

Plugins can expose more than one way for Codex to use them: App connectors for ChatGPT/SIWC-backed sessions and MCP servers for API key login sessions. The broader goal is to make PluginsManager the place that understands which plugin surfaces should be visible for the current auth route, so callers do not each have to make that decision themselves.

This PR is the small setup step for that work. It lets the plugin manager be created with the current AuthMode, which gives the followup auth routing PRs the information they need without relying on setter injection.

Stack

Summary

  • Let PluginsManager::new_with_restriction_product accept an initial AuthMode.
  • Keep PluginsManager::new behavior unchanged for ordinary callers.

Validation

cargo test -p codex-core-plugins plugins_manager_tracks_auth_mode
cargo test -p codex-core list_tool_suggest_discoverable_plugins
git diff --check

@felixxia-oai felixxia-oai changed the title [codex] Seed plugin manager auth at construction [codex] Add auth mode to plugin manager constructor Jun 11, 2026
@felixxia-oai
felixxia-oai requested a review from xl-openai June 11, 2026 18:57
@felixxia-oai
felixxia-oai force-pushed the plugin-auth-manager-constructor branch from 495f1f4 to c9ab74c Compare June 11, 2026 19:59
@felixxia-oai

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown
Contributor

Codex Review: Didn't find any major issues. Swish!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@felixxia-oai
felixxia-oai marked this pull request as ready for review June 11, 2026 20:37
@felixxia-oai
felixxia-oai requested a review from a team as a code owner June 11, 2026 20:37

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c9ab74cec3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/core-plugins/src/manager.rs
@github-actions

github-actions Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@felixxia-oai

Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@felixxia-oai

Copy link
Copy Markdown
Contributor Author

recheck

@felixxia-oai
felixxia-oai force-pushed the plugin-auth-manager-constructor branch 2 times, most recently from a6b6373 to df88645 Compare June 11, 2026 21:12
@xl-openai

Copy link
Copy Markdown
Contributor

@codex review again

@chatgpt-codex-connector

Copy link
Copy Markdown
Contributor

Codex Review: Didn't find any major issues. Can't wait for the next one!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/core-plugins/src/manager.rs Outdated
@felixxia-oai
felixxia-oai force-pushed the plugin-auth-manager-constructor branch from df88645 to ba2f04d Compare June 12, 2026 09:38
@xl-openai
xl-openai force-pushed the plugin-auth-manager-constructor branch from 490f500 to 57bc034 Compare June 13, 2026 00:28
@xl-openai
xl-openai merged commit aef40ad into main Jun 13, 2026
31 checks passed
@xl-openai
xl-openai deleted the plugin-auth-manager-constructor branch June 13, 2026 01:00
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 13, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants