Use aws-lc-rs for rustls crypto provider#27706
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8135b99cfc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
8135b99 to
a4efc30
Compare
|
I have read the CLA Document and I hereby sign the CLA |
a4efc30 to
ecbee60
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ecbee60436
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ecbee60 to
4133ae0
Compare
Why
Some enterprise TLS proxies issue certificate chains signed with
ecdsa_secp521r1_sha512/ECDSA_NISTP521_SHA512. Custom CA configuration such asSSL_CERT_FILEcan add the right trust root, but it cannot makerustls'sringverifier support a certificate signature algorithm it does not advertise.That can still break TLS after the CA bundle is configured, including on Rust websocket paths that call the shared
ensure_rustls_crypto_provider()helper, such as the Responses websocket connector and remote app-server client:codex-api/src/endpoint/responses_websocket.rsapp-server-client/src/remote.rsThe
aws-lc-rsrustlsprovider supports this P-521/SHA-512 certificate signature scheme, so use it as Codex's process-widerustlsprovider.What Changed
rustlsfeature fromringtoaws_lc_rs.codex-utils-rustls-providerto installrustls::crypto::aws_lc_rs::default_provider().ECDSA_NISTP521_SHA512.Verification
just fmt just test -p codex-utils-rustls-provider just bazel-lock-update just bazel-lock-check