Skip to content

Fix image extension PathUri conversion#27711

Merged
anp-oai merged 1 commit into
mainfrom
codex/fix-image-generation-path-uri
Jun 12, 2026
Merged

Fix image extension PathUri conversion#27711
anp-oai merged 1 commit into
mainfrom
codex/fix-image-generation-path-uri

Conversation

@anp-oai

@anp-oai anp-oai commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Why

main stopped compiling when #27498 passed an AbsolutePathBuf to the ExecutorFileSystem API migrated to PathUri by #27653.

What

Convert referenced image paths to PathUri before filesystem reads, declare the internal path-URI dependency, and refresh Cargo.lock.

@anp-oai
anp-oai marked this pull request as ready for review June 11, 2026 23:57
@anp-oai
anp-oai enabled auto-merge (squash) June 11, 2026 23:57

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d25e3c737d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/ext/image-generation/Cargo.toml
@anp-oai
anp-oai force-pushed the codex/fix-image-generation-path-uri branch from d25e3c7 to 0ebb68a Compare June 12, 2026 00:00

@won-openai won-openai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anp-oai
anp-oai merged commit 1829ed1 into main Jun 12, 2026
31 checks passed
@anp-oai
anp-oai deleted the codex/fix-image-generation-path-uri branch June 12, 2026 00:15
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 12, 2026
@charlesgong-openai
charlesgong-openai restored the codex/fix-image-generation-path-uri branch June 13, 2026 02:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants