Skip to content

Remove terminal resize reflow flag gates#27794

Merged
etraut-openai merged 1 commit into
mainfrom
etraut/terminal-resize-reflow-removed
Jun 15, 2026
Merged

Remove terminal resize reflow flag gates#27794
etraut-openai merged 1 commit into
mainfrom
etraut/terminal-resize-reflow-removed

Conversation

@etraut-openai

Copy link
Copy Markdown
Collaborator

Why

terminal_resize_reflow is now stable and should behave as always on. Keeping the disabled runtime paths around made the feature look configurable even though the rollout is complete, and old config could still suggest there was a supported off mode.

What Changed

  • Marked terminal_resize_reflow as Stage::Removed while keeping it default-enabled for compatibility.
  • Ignored [features].terminal_resize_reflow config entries so stale false settings no longer affect the effective feature set.
  • Removed TUI branches that depended on the flag being disabled, so draw, replay buffering, stream finalization, and resize scheduling all assume resize reflow is active.
  • Simplified resize smoke coverage to exercise the always-on behavior only.

Verification

  • just test -p codex-features
  • just test -p codex-tui resize_reflow
  • just test -p codex-tui initial_replay_buffer thread_switch_replay_buffer

@etraut-openai etraut-openai changed the title [codex] Remove terminal resize reflow flag gates Remove terminal resize reflow flag gates Jun 12, 2026
@etraut-openai etraut-openai marked this pull request as ready for review June 12, 2026 06:36
@etraut-openai etraut-openai force-pushed the etraut/terminal-resize-reflow-removed branch from 86a86e8 to a42dd05 Compare June 14, 2026 19:59

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a42dd05a61

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/features/src/lib.rs
Comment thread codex-rs/features/src/lib.rs
Comment thread codex-rs/features/src/lib.rs

@fcoury-oai fcoury-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with and without the setting, code looks good 👍

@etraut-openai etraut-openai merged commit 8a6a039 into main Jun 15, 2026
31 checks passed
@etraut-openai etraut-openai deleted the etraut/terminal-resize-reflow-removed branch June 15, 2026 15:23
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 15, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants