Skip to content

[codex] Make plugin details capability aware#27958

Merged
felixxia-oai merged 6 commits into
mainfrom
plugin-auth-context-aware-plugin-details
Jun 16, 2026
Merged

[codex] Make plugin details capability aware#27958
felixxia-oai merged 6 commits into
mainfrom
plugin-auth-context-aware-plugin-details

Conversation

@felixxia-oai

@felixxia-oai felixxia-oai commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Summary

Makes plugin details/read flows capability-aware so auth-filtered plugin surfaces report the same usable app/MCP/skill shape as the marketplace and install flows.

Validation

Not run; this change was rebased onto the current plugin auth stack and pushed as a draft PR.

Manual test

  1. set up a local marketplace with a plugin that has both app and mcp declarations
// .app.json
{
  "apps": {
    "linear": {
      "id": "some_id"
    }
  }
}

// .mcp.json
{
  "mcpServers": {
    "linear": {
      "type": "http",
      "url": "https://mcp.linear.app/mcp",
      "oauth_resource": "https://mcp.linear.app/mcp"
    },
    "linear2": {
      "type": "http",
      "url": "https://mcp.linear2.app/mcp",
      "oauth_resource": "https://mcp.linear2.app/mcp"
    }
  }
}

2a. login in with api key and observe plugin details page which shows no apps (note we don't show "app not available due to api key log in as there's no way to differentiate between no apps and app without substitute mcp exists" without significantly more code changes, i've separated this to a follow up if we want that behaviour.
Screenshot 2026-06-15 at 23 45 40
Screenshot 2026-06-15 at 18 40 30

2b. log in with chat and observe intended conflict resolution logic
Screenshot 2026-06-15 at 17 17 30
Screenshot 2026-06-15 at 18 38 59

@felixxia-oai
felixxia-oai force-pushed the plugin-auth-context-aware-git-install-recheck branch from 6dd2ff5 to 7990855 Compare June 12, 2026 21:53
@felixxia-oai
felixxia-oai force-pushed the plugin-auth-context-aware-plugin-details branch from 34a526a to 23e47e6 Compare June 12, 2026 21:53
@felixxia-oai
felixxia-oai force-pushed the plugin-auth-context-aware-git-install-recheck branch from 7990855 to 861a599 Compare June 12, 2026 22:14
@felixxia-oai
felixxia-oai force-pushed the plugin-auth-context-aware-plugin-details branch 2 times, most recently from 599d127 to c6a4457 Compare June 12, 2026 22:20
@felixxia-oai
felixxia-oai force-pushed the plugin-auth-context-aware-git-install-recheck branch from 8418596 to 0756089 Compare June 15, 2026 11:52
@felixxia-oai
felixxia-oai force-pushed the plugin-auth-context-aware-plugin-details branch from c6a4457 to 15a520a Compare June 15, 2026 11:52
@felixxia-oai
felixxia-oai force-pushed the plugin-auth-context-aware-git-install-recheck branch from 0756089 to c1181eb Compare June 15, 2026 12:52
@felixxia-oai
felixxia-oai force-pushed the plugin-auth-context-aware-plugin-details branch 2 times, most recently from 325eb4d to b4b3b01 Compare June 15, 2026 13:07
@felixxia-oai
felixxia-oai force-pushed the plugin-auth-context-aware-git-install-recheck branch from c1181eb to 9093548 Compare June 15, 2026 13:07
@felixxia-oai
felixxia-oai force-pushed the plugin-auth-context-aware-plugin-details branch from b4b3b01 to f1a1f07 Compare June 15, 2026 15:36
@felixxia-oai
felixxia-oai force-pushed the plugin-auth-context-aware-git-install-recheck branch from 9093548 to e7918b6 Compare June 15, 2026 15:36
@felixxia-oai
felixxia-oai force-pushed the plugin-auth-context-aware-plugin-details branch from f1a1f07 to b1341c7 Compare June 15, 2026 15:48
@felixxia-oai
felixxia-oai requested a review from xl-openai June 15, 2026 16:40
@felixxia-oai
felixxia-oai force-pushed the plugin-auth-context-aware-plugin-details branch from 12f5206 to a727e2f Compare June 15, 2026 16:43
@felixxia-oai
felixxia-oai force-pushed the plugin-auth-context-aware-git-install-recheck branch from 467f3c5 to 2cc5786 Compare June 15, 2026 16:45
@felixxia-oai
felixxia-oai force-pushed the plugin-auth-context-aware-plugin-details branch from a727e2f to 0ed374c Compare June 15, 2026 16:46
@felixxia-oai
felixxia-oai marked this pull request as ready for review June 15, 2026 17:48

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0ed374c08a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/app-server/src/request_processors/plugins.rs Outdated
Comment thread codex-rs/tui/src/chatwidget/tests/popups_and_settings.rs Outdated
@felixxia-oai
felixxia-oai force-pushed the plugin-auth-context-aware-plugin-details branch from 0ed374c to 337bebc Compare June 15, 2026 18:48
@felixxia-oai
felixxia-oai changed the base branch from plugin-auth-context-aware-git-install-recheck to plugin-auth-capability-resolver June 15, 2026 18:48
@felixxia-oai
felixxia-oai requested a review from a team as a code owner June 15, 2026 19:32
@felixxia-oai
felixxia-oai marked this pull request as draft June 15, 2026 19:33
@felixxia-oai
felixxia-oai marked this pull request as ready for review June 15, 2026 19:33
@felixxia-oai
felixxia-oai force-pushed the plugin-auth-context-aware-plugin-details branch from 55973b4 to 337bebc Compare June 15, 2026 19:36

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 55973b4a8a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/core-plugins/src/manager.rs Outdated
Comment thread codex-rs/core/src/tools/handlers/request_plugin_install.rs Outdated
Comment thread codex-rs/cli/src/plugin_cmd.rs Outdated
Comment thread codex-rs/tui/src/chatwidget/plugins.rs Outdated
@felixxia-oai
felixxia-oai force-pushed the plugin-auth-context-aware-plugin-details branch 2 times, most recently from 60b6204 to 407ad58 Compare June 15, 2026 22:22
@felixxia-oai
felixxia-oai force-pushed the plugin-auth-context-aware-plugin-details branch from 407ad58 to c16b8fe Compare June 15, 2026 22:33
Comment thread codex-rs/app-server/src/request_processors/plugins.rs Outdated

@xl-openai xl-openai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please cleanup plugin_details_app_summaries_enabled before merge.

@felixxia-oai
felixxia-oai force-pushed the plugin-auth-context-aware-plugin-details branch 2 times, most recently from 490f02e to 993f514 Compare June 16, 2026 00:00
Base automatically changed from plugin-auth-capability-resolver to main June 16, 2026 00:13
@felixxia-oai
felixxia-oai enabled auto-merge (squash) June 16, 2026 00:22
@felixxia-oai
felixxia-oai force-pushed the plugin-auth-context-aware-plugin-details branch from e683cd4 to 1308447 Compare June 16, 2026 01:07
@felixxia-oai
felixxia-oai merged commit d959664 into main Jun 16, 2026
31 checks passed
@felixxia-oai
felixxia-oai deleted the plugin-auth-context-aware-plugin-details branch June 16, 2026 01:25
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants