[ez][codex-rs] Support apps._default.default_tools_approval_mode#27965
Merged
zamoshchin-openai merged 8 commits intoJun 17, 2026
Conversation
…t-tool-approval-mode # Conflicts: # codex-rs/core/src/connectors.rs # codex-rs/core/src/connectors_tests.rs
…t-tool-approval-mode
…t-tool-approval-mode
jif-oai
reviewed
Jun 16, 2026
| let approval = managed_approval | ||
| .or_else(|| tool_config.and_then(|tool| tool.approval_mode)) | ||
| .or_else(|| app.and_then(|app| app.default_tools_approval_mode)) | ||
| .or_else(|| { |
Contributor
There was a problem hiding this comment.
Could we avoid applying apps._default when connector_id is missing? Execution re-looks metadata up from the mutable Apps cache, so an already-registered handler can lose its connector after a hard refresh
jif-oai
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[from codex]
Summary
default_tools_approval_modeto[apps._default]and expose it through app-server v2config/readautofallbackConfiguration
The effective precedence is managed requirements, tool-specific
approval_mode, app-specificdefault_tools_approval_mode,apps._default.default_tools_approval_mode, thenauto.Test plan
just write-config-schemajust write-app-server-schemajust write-app-server-schema --experimentaljust test -p codex-core app_tool_policyjust test -p codex-core mcp_turn_metadatajust test -p codex-configjust test -p codex-app-server-protocoljust test -p codex-app-server config_read_includes_appsjust fix -p codex-config -p codex-core -p codex-app-server-protocol -p codex-app-serverjust fmt