[codex] preserve explicit environment cwd#27995
Merged
pakrym-oai merged 1 commit intoJun 15, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0b69f15b73
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
anp-oai
approved these changes
Jun 15, 2026
sayan-oai
approved these changes
Jun 15, 2026
pakrym-oai
force-pushed
the
pakrym/full-ci-delete-primary-environment-cwd-override
branch
from
June 15, 2026 16:59
3ab3ee2 to
b45c72c
Compare
pakrym-oai
force-pushed
the
pakrym/full-ci-delete-primary-environment-cwd-override
branch
from
June 15, 2026 17:04
b45c72c to
b36c87b
Compare
pakrym-oai
enabled auto-merge (squash)
June 15, 2026 17:11
pakrym-oai
deleted the
pakrym/full-ci-delete-primary-environment-cwd-override
branch
June 15, 2026 17:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
TurnEnvironmentSelections::newrewrote the primary environment's explicitcwdto the legacy fallback cwd. For a remote-first selection, this could replace the remote working directory with a local fallback path and made the legacy cwd overlay authoritative over environment-owned state.What changed
cwd-only app-server updates compatible by rebuilding the default environment selections at the requested cwd.Testing
just test -p codex-core session_update_settings_does_not_rewrite_sticky_environment_cwdsjust test -p codex-core environment_settings_preserve_explicit_primary_cwdjust test -p codex-app-server thread_settings_update_cwd_retargets_default_environment