[codex] package Windows ARM64 on x64#28001
Conversation
The first release after parallelizing Windows packaging moved the critical path to the ARM64 packaging job: https://github.com/openai/codex/actions/runs/27451157324 The x64 job started immediately and finished in 5m29s. The ARM64 job waited 76s for its runner and then took 5m56s, holding the release for 1m43s after x64 had finished. Packaging only downloads, signs, archives, and compresses already built binaries. It does not execute target code. Run both packaging jobs on x64 runners, keeping ARM64 hardware for compilation.
| path: codex-rs/symbols-dist/${{ matrix.target }}/* | ||
| if-no-files-found: error | ||
|
|
||
| build-windows: |
There was a problem hiding this comment.
it is pretty confusing that this is called build-windows when it does everything except build
There was a problem hiding this comment.
yeah i'm guessing this was a casualty of some successive refactors here, i'd support a followup to pick a better name that isn't shadowed by the alias the release.yml file uses for this whole workflow. maybe something like assemble-and-upload-artifacts or similar? cc @bolinfest
There was a problem hiding this comment.
let me know either here or in slack if you want that followup. until then, does this LGTY?
There was a problem hiding this comment.
Oh sorry, thought I approved when I left this comment. Michael's OOO for a bit anyways and I hadn't realized when I commented so not worth blocking on his input. Don't worry about the follow-up for now, I'm still pretty new and not sure I can check all the places where I'd want to find out it's load bearing.
anp-oai
left a comment
anp-oai
left a comment
There was a problem hiding this comment.
For posterity: putting together the arm64 release archives on an x86_64 machine should be safe, we're not actually doing any cross compilation or host-specific work here.
2 participants
The first release after parallelizing Windows packaging moved the
critical path to the ARM64 packaging job:
https://github.com/openai/codex/actions/runs/27451157324
The x64 job started immediately and finished in 5m29s. The ARM64
job waited 76s for its runner and then took 5m56s, holding the
release for 1m43s after x64 had finished.
Packaging only downloads, signs, archives, and compresses already
built binaries. It does not execute target code. Run both packaging
jobs on x64 runners, keeping ARM64 hardware for compilation.