Add experimental local credential broker#28034
Open
winston-openai wants to merge 3 commits into
Open
Conversation
5446ca3 to
006a77a
Compare
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 006a77a3d6
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
winston-openai
added a commit
that referenced
this pull request
Jun 16, 2026
winston-openai
added a commit
that referenced
this pull request
Jun 16, 2026
winston-openai
added a commit
that referenced
this pull request
Jun 16, 2026
This was referenced Jun 16, 2026
winston-openai
added a commit
that referenced
this pull request
Jun 16, 2026
winston-openai
added a commit
that referenced
this pull request
Jun 16, 2026
winston-openai
added a commit
that referenced
this pull request
Jun 17, 2026
This was referenced Jun 17, 2026
f992518 to
732cf55
Compare
807dfe6 to
f52cce3
Compare
403dd8e to
99eeb43
Compare
99eeb43 to
9204084
Compare
…dential-broker-review-20260618
…dential-broker-review-20260618
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Codex child processes can inherit injectable local credentials directly, which lets commands read and exfiltrate the real values. This first experimental slice keeps supported workflows working while moving those credentials behind the existing managed network proxy.
What changed
credential_broker = trueunder[features.network_proxy]Authorizationheaders that do not contain a broker dummyGH_HOST, and bind OpenAI keys only toapi.openai.com1, preventing ordinary proxy sessions from restoring ambient credentialscodex-network-proxy; the smallcodex-coreintegration only maps feature config and handles the existing shell snapshot and escalation boundariesScope
GH_TOKEN,GITHUB_TOKEN,GH_ENTERPRISE_TOKEN,GITHUB_ENTERPRISE_TOKEN, andOPENAI_API_KEYgithub.com,api.github.com, and*.ghe.comGH_HOSTapi.openai.comValidation
just test -p codex-network-proxy(184 passed)just test -p codex-features(52 passed)codex-corechecks for active broker shell-snapshot replay and inactive broker credential omissioncodex-network-proxy,codex-features, andcodex-core