Skip to content

build: run buildifier from just fmt#28125

Merged
anp-oai merged 5 commits into
mainfrom
codex/buildifier-formatting
Jun 14, 2026
Merged

build: run buildifier from just fmt#28125
anp-oai merged 5 commits into
mainfrom
codex/buildifier-formatting

Conversation

@anp-oai

@anp-oai anp-oai commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

Intent

Keep Bazel and Starlark files consistently formatted without requiring contributors to install or version buildifier themselves.

Implementation

  • Add a SHA-256-pinned, cross-platform DotSlash manifest for buildifier v8.5.1.
  • Run buildifier from the shared just fmt and just fmt-check driver, with Windows-safe explicit DotSlash invocation.
  • Provision DotSlash in formatting CI and contributor devcontainers, and document the source-build prerequisite.
  • Apply the initial mechanical buildifier formatting baseline.

@anp-oai
anp-oai marked this pull request as ready for review June 13, 2026 22:51
@anp-oai
anp-oai requested a review from a team as a code owner June 13, 2026 22:51
@anp-oai

anp-oai commented Jun 13, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7790dbe973

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docs/install.md
Comment thread scripts/format.py Outdated
Comment thread scripts/format.py
@anp-oai
anp-oai merged commit 740c4f2 into main Jun 14, 2026
45 checks passed
@anp-oai
anp-oai deleted the codex/buildifier-formatting branch June 14, 2026 04:43
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants