[codex] Use local environment for user shell commands#28163
Merged
Conversation
pakrym-oai
marked this pull request as ready for review
June 14, 2026 06:10
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bb47c79360
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
pakrym-oai
force-pushed
the
pakrym/full-ci-unified-exec-shell-processing
branch
from
June 14, 2026 06:25
bb47c79 to
8884d17
Compare
pakrym-oai
changed the title
pakrym-oai
force-pushed
the
pakrym/full-ci-unified-exec-shell-processing
branch
2 times, most recently
from
June 14, 2026 06:31
9f648ab to
a730f12
Compare
pakrym-oai
force-pushed
the
pakrym/full-ci-unified-exec-shell-processing
branch
from
June 16, 2026 03:19
a730f12 to
b6c705b
Compare
pakrym-oai
enabled auto-merge (squash)
June 16, 2026 04:05
sayan-oai
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
User shell commands still read the legacy turn cwd and session shell even though execution context is now owned by selected turn environments. App-server also defines
thread/shellCommandas a local-host escape hatch, so it must use an available local environment even when a remote environment is primary.What changed
ResolvedTurnEnvironments::local()to find the selected local environment.TurnEnvironment.shell is unavailable in this sessionerror when no selected local environment or resolved local shell is available./shellwithout a local environment.Test plan
just test -p codex-core user_shell_command_without_local_environment_emits_error